Drop python2 support #214
Drop python2 support #214
Conversation
unify between Python 2 and 3)
|
I also think we should drop everything that older 3.6: https://repology.org/project/python3/versions |
python/test-r_bp.py
Outdated
| @@ -1,4 +1,4 @@ | |||
| #!/usr/bin/python2 | |||
| #!/usr/bin/env python | |||
There was a problem hiding this comment.
Shouldn't we use /usr/bin/env python3 for now? Just in case.
| python3.6 | ||
| python35 | ||
| python3.5 | ||
| python34 |
There was a problem hiding this comment.
drop old 3.x versions maybe?
mp.py
Outdated
| @@ -1,4 +1,4 @@ | |||
| #!/usr/bin/python2 | |||
| #!/usr/bin/env python | |||
`#!/usr/bin/env python` for now, to make sure Python 3 is used.
I'm all for newer versions, but dropping older versions of Python 3 seems unnecessary - the only difference is the call to |
were differentiated between 2 and 3
|
The latest commit now builds I guess that once this gets merged, we should also update the r2pm repo to include just lang_python, instead of lang_python2 and lang_python3. However, this switch will require a manual update from an older version of lang_python3 to the new lang_python. Is that OK? |
|
Yes, I think that's OK. Thank you! |
|
Merging this to let people test and catch bug early. |
As per #206, remove Python 2 support.
Note: I haven't completely tested the win32 compilation on Wine. I updated the download to use the latest Python 3 available as an MSI package (since later Python 3 versions fail to install successfully under Wine), but
makefails due to other errors that I didn't feel like diving into. If anyone knows how the build of the w32 Python bindings works and can test its functionality, that'll be great.