[WIP] OeX_Depr-112 Account pages -> micro-frontend #2419
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UvgenGen
force-pushed
the
depr/account-pages
branch
3 times, most recently
from
79a14c2 to
fa2d15e
Compare
dyudyunov
reviewed
May 2, 2022
|
|
||
| If duplicate is True, we expect context['duplicate_provider'] to contain | ||
| # pylint: disable=invalid-name |
| # pylint: disable=invalid-name | ||
| def assert_third_party_accounts_state(self, request, duplicate=False, linked=None): | ||
| """ | ||
| Asserts the user's third party account in the expected state. |
There was a problem hiding this comment.
Docstring title should be separated from docstring body by the new line
| @@ -495,7 +495,7 @@ def test_login_user_info_cookie(self): | |||
|
|
|||
| # Check that the URLs are absolute | |||
| for url in user_info["header_urls"].values(): | |||
| assert 'http://testserver/' in url | |||
| assert 'http://' in url | |||
There was a problem hiding this comment.
we don't use the domain because some urls in the header have been changed. (account and profile urls)
idegtiarov
approved these changes
May 2, 2022
UvgenGen
force-pushed
the
depr/account-pages
branch
2 times, most recently
from
2ae2c2e to
ad1d14e
Compare
UvgenGen
force-pushed
the
depr/account-pages
branch
from
ad1d14e to
94abf32
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OeX_Depr-112 Account pages -> micro-frontend
openedx/public-engineering#71