Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nfts): add CollectionApprovals and AccountBalance storages, and general improvements #387

Merged
merged 104 commits into from
Jan 15, 2025

chore: update weight

8b4c4c4
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

feat(nfts): add CollectionApprovals and AccountBalance storages, and general improvements #387

chore: update weight
8b4c4c4
Select commit
Loading
Failed to load commit list.
GitHub Actions / clippy succeeded Jan 14, 2025 in 3s

clippy

249 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 0
Warning 249
Note 0
Help 0

Versions

  • rustc 1.84.0 (9fc6b4312 2025-01-07)
  • cargo 1.84.0 (66221abde 2024-11-19)
  • clippy 0.1.84 (9fc6b43126 2025-01-07)

Annotations

Check warning on line 44 in node/src/cli.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

large size difference between variants

warning: large size difference between variants
  --> node/src/cli.rs:5:1
   |
5  | / pub enum Subcommand {
6  | |     /// Build a chain specification.
7  | |     BuildSpec(sc_cli::BuildSpecCmd),
...  |
19 | |     ImportBlocks(sc_cli::ImportBlocksCmd),
   | |     ------------------------------------- the second-largest variant contains at least 240 bytes
...  |
39 | |     Benchmark(frame_benchmarking_cli::BenchmarkCmd),
   | |     ----------------------------------------------- the largest variant contains at least 544 bytes
...  |
43 | |     Key(sc_cli::KeySubcommand),
44 | | }
   | |_^ the entire enum is at least 544 bytes
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant
   = note: `#[warn(clippy::large_enum_variant)]` on by default
help: consider boxing the large fields to reduce the total size of the enum
   |
39 |     Benchmark(Box<frame_benchmarking_cli::BenchmarkCmd>),
   |               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Check warning on line 1008 in runtime/testnet/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a function

warning: missing documentation for a function
    --> runtime/testnet/src/lib.rs:661:1
     |
661  | / impl_runtime_apis! {
662  | |
663  | |     impl sp_consensus_aura::AuraApi<Block, AuraId> for Runtime {
664  | |         fn slot_duration() -> sp_consensus_aura::SlotDuration {
...    |
1007 | |     }
1008 | | }
     | |_^
     |
     = note: this warning originates in the macro `impl_runtime_apis` (in Nightly builds, run with -Z macro-backtrace for more info)

Check warning on line 128 in runtime/testnet/src/config/xcm.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a struct

warning: missing documentation for a struct
   --> runtime/testnet/src/config/xcm.rs:128:1
    |
128 | pub struct XcmConfig;
    | ^^^^^^^^^^^^^^^^^^^^

Check warning on line 126 in runtime/testnet/src/config/xcm.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a type alias

warning: missing documentation for a type alias
   --> runtime/testnet/src/config/xcm.rs:126:1
    |
126 | pub type TrustedReserves = (NativeAsset, NativeAssetFrom<AssetHub>);
    | ^^^^^^^^^^^^^^^^^^^^^^^^

Check warning on line 101 in runtime/testnet/src/config/xcm.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a type alias

warning: missing documentation for a type alias
   --> runtime/testnet/src/config/xcm.rs:101:1
    |
101 | pub type Barrier = TrailingSetTopicAsId<(
    | ^^^^^^^^^^^^^^^^

Check warning on line 94 in runtime/testnet/src/config/xcm.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a struct

warning: missing documentation for a struct
  --> runtime/testnet/src/config/xcm.rs:94:1
   |
94 | pub struct ParentOrParentsExecutivePlurality;
   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Check warning on line 265 in /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/frame-support-36.0.0/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a struct

warning: missing documentation for a struct
  --> runtime/testnet/src/config/xcm.rs:87:1
   |
87 | / parameter_types! {
88 | |     // One XCM operation is 1_000_000_000 weight - almost certainly a conservative estimate.
89 | |     pub UnitWeightCost: Weight = Weight::from_parts(1_000_000_000, 64 * 1024);
90 | |     pub const MaxInstructions: u32 = 100;
91 | |     pub const MaxAssetsIntoHolding: u32 = 64;
92 | | }
   | |_^
   |
   = note: this warning originates in the macro `$crate::parameter_types` which comes from the expansion of the macro `parameter_types` (in Nightly builds, run with -Z macro-backtrace for more info)

Check warning on line 265 in /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/frame-support-36.0.0/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a struct

warning: missing documentation for a struct
  --> runtime/testnet/src/config/xcm.rs:87:1
   |
87 | / parameter_types! {
88 | |     // One XCM operation is 1_000_000_000 weight - almost certainly a conservative estimate.
89 | |     pub UnitWeightCost: Weight = Weight::from_parts(1_000_000_000, 64 * 1024);
90 | |     pub const MaxInstructions: u32 = 100;
91 | |     pub const MaxAssetsIntoHolding: u32 = 64;
92 | | }
   | |_^
   |
   = note: this warning originates in the macro `$crate::parameter_types` which comes from the expansion of the macro `parameter_types` (in Nightly builds, run with -Z macro-backtrace for more info)

Check warning on line 277 in /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/frame-support-36.0.0/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a struct

warning: missing documentation for a struct
  --> runtime/testnet/src/config/xcm.rs:87:1
   |
87 | / parameter_types! {
88 | |     // One XCM operation is 1_000_000_000 weight - almost certainly a conservative estimate.
89 | |     pub UnitWeightCost: Weight = Weight::from_parts(1_000_000_000, 64 * 1024);
90 | |     pub const MaxInstructions: u32 = 100;
91 | |     pub const MaxAssetsIntoHolding: u32 = 64;
92 | | }
   | |_^
   |
   = note: this warning originates in the macro `parameter_types` (in Nightly builds, run with -Z macro-backtrace for more info)

Check warning on line 277 in /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/frame-support-36.0.0/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a struct

warning: missing documentation for a struct
  --> runtime/testnet/src/config/xcm.rs:28:1
   |
28 | / parameter_types! {
29 | |     pub const RelayLocation: Location = Location::parent();
30 | |     pub AssetHub: Location = Location::new(1, [Parachain(1000)]);
31 | |     // Note: Paseo currently uses Polkadot https://github.com/paseo-network/runtimes/blob/abc4ae9c5ae8f0166aab7ef2b427b3c2c6d5ce5c/relay/...
...  |
36 | |     pub UniversalLocation: InteriorLocation = Parachain(ParachainInfo::parachain_id().into()).into();
37 | | }
   | |_^
   |
   = note: this warning originates in the macro `$crate::parameter_types` which comes from the expansion of the macro `parameter_types` (in Nightly builds, run with -Z macro-backtrace for more info)

Check warning on line 277 in /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/frame-support-36.0.0/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a struct

warning: missing documentation for a struct
  --> runtime/testnet/src/config/xcm.rs:28:1
   |
28 | / parameter_types! {
29 | |     pub const RelayLocation: Location = Location::parent();
30 | |     pub AssetHub: Location = Location::new(1, [Parachain(1000)]);
31 | |     // Note: Paseo currently uses Polkadot https://github.com/paseo-network/runtimes/blob/abc4ae9c5ae8f0166aab7ef2b427b3c2c6d5ce5c/relay/...
...  |
36 | |     pub UniversalLocation: InteriorLocation = Parachain(ParachainInfo::parachain_id().into()).into();
37 | | }
   | |_^
   |
   = note: this warning originates in the macro `$crate::parameter_types` which comes from the expansion of the macro `parameter_types` (in Nightly builds, run with -Z macro-backtrace for more info)

Check warning on line 265 in /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/frame-support-36.0.0/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a struct

warning: missing documentation for a struct
  --> runtime/testnet/src/config/xcm.rs:28:1
   |
28 | / parameter_types! {
29 | |     pub const RelayLocation: Location = Location::parent();
30 | |     pub AssetHub: Location = Location::new(1, [Parachain(1000)]);
31 | |     // Note: Paseo currently uses Polkadot https://github.com/paseo-network/runtimes/blob/abc4ae9c5ae8f0166aab7ef2b427b3c2c6d5ce5c/relay/...
...  |
36 | |     pub UniversalLocation: InteriorLocation = Parachain(ParachainInfo::parachain_id().into()).into();
37 | | }
   | |_^
   |
   = note: this warning originates in the macro `$crate::parameter_types` which comes from the expansion of the macro `parameter_types` (in Nightly builds, run with -Z macro-backtrace for more info)

Check warning on line 277 in /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/frame-support-36.0.0/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a struct

warning: missing documentation for a struct
  --> runtime/testnet/src/config/xcm.rs:28:1
   |
28 | / parameter_types! {
29 | |     pub const RelayLocation: Location = Location::parent();
30 | |     pub AssetHub: Location = Location::new(1, [Parachain(1000)]);
31 | |     // Note: Paseo currently uses Polkadot https://github.com/paseo-network/runtimes/blob/abc4ae9c5ae8f0166aab7ef2b427b3c2c6d5ce5c/relay/...
...  |
36 | |     pub UniversalLocation: InteriorLocation = Parachain(ParachainInfo::parachain_id().into()).into();
37 | | }
   | |_^
   |
   = note: this warning originates in the macro `$crate::parameter_types` which comes from the expansion of the macro `parameter_types` (in Nightly builds, run with -Z macro-backtrace for more info)

Check warning on line 265 in /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/frame-support-36.0.0/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a struct

warning: missing documentation for a struct
  --> runtime/testnet/src/config/xcm.rs:28:1
   |
28 | / parameter_types! {
29 | |     pub const RelayLocation: Location = Location::parent();
30 | |     pub AssetHub: Location = Location::new(1, [Parachain(1000)]);
31 | |     // Note: Paseo currently uses Polkadot https://github.com/paseo-network/runtimes/blob/abc4ae9c5ae8f0166aab7ef2b427b3c2c6d5ce5c/relay/...
...  |
36 | |     pub UniversalLocation: InteriorLocation = Parachain(ParachainInfo::parachain_id().into()).into();
37 | | }
   | |_^
   |
   = note: this warning originates in the macro `parameter_types` (in Nightly builds, run with -Z macro-backtrace for more info)

Check warning on line 106 in runtime/testnet/src/config/assets.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a type alias

warning: missing documentation for a type alias
   --> runtime/testnet/src/config/assets.rs:106:1
    |
106 | pub type TrustBackedAssetsCall = pallet_assets::Call<Runtime, TrustBackedAssetsInstance>;
    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Check warning on line 277 in /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/frame-support-36.0.0/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a struct

warning: missing documentation for a struct
  --> runtime/testnet/src/config/assets.rs:79:1
   |
79 | / parameter_types! {
80 | |     pub const NftFractionalizationPalletId: PalletId = PalletId(*b"fraction");
81 | |     pub NewAssetSymbol: BoundedVec<u8, AssetsStringLimit> = (*b"FRAC").to_vec().try_into().unwrap();
82 | |     pub NewAssetName: BoundedVec<u8, AssetsStringLimit> = (*b"Frac").to_vec().try_into().unwrap();
83 | | }
   | |_^
   |
   = note: this warning originates in the macro `$crate::parameter_types` which comes from the expansion of the macro `parameter_types` (in Nightly builds, run with -Z macro-backtrace for more info)

Check warning on line 277 in /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/frame-support-36.0.0/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a struct

warning: missing documentation for a struct
  --> runtime/testnet/src/config/assets.rs:79:1
   |
79 | / parameter_types! {
80 | |     pub const NftFractionalizationPalletId: PalletId = PalletId(*b"fraction");
81 | |     pub NewAssetSymbol: BoundedVec<u8, AssetsStringLimit> = (*b"FRAC").to_vec().try_into().unwrap();
82 | |     pub NewAssetName: BoundedVec<u8, AssetsStringLimit> = (*b"Frac").to_vec().try_into().unwrap();
83 | | }
   | |_^
   |
   = note: this warning originates in the macro `$crate::parameter_types` which comes from the expansion of the macro `parameter_types` (in Nightly builds, run with -Z macro-backtrace for more info)

Check warning on line 265 in /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/frame-support-36.0.0/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a struct

warning: missing documentation for a struct
  --> runtime/testnet/src/config/assets.rs:79:1
   |
79 | / parameter_types! {
80 | |     pub const NftFractionalizationPalletId: PalletId = PalletId(*b"fraction");
81 | |     pub NewAssetSymbol: BoundedVec<u8, AssetsStringLimit> = (*b"FRAC").to_vec().try_into().unwrap();
82 | |     pub NewAssetName: BoundedVec<u8, AssetsStringLimit> = (*b"Frac").to_vec().try_into().unwrap();
83 | | }
   | |_^
   |
   = note: this warning originates in the macro `parameter_types` (in Nightly builds, run with -Z macro-backtrace for more info)

Check warning on line 265 in /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/frame-support-36.0.0/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a struct

warning: missing documentation for a struct
  --> runtime/testnet/src/config/assets.rs:30:1
   |
30 | / parameter_types! {
31 | |     pub NftsPalletFeatures: PalletFeatures = PalletFeatures::all_enabled();
32 | |     // Key = 68 bytes (4+16+32+16), Value = 52 bytes (4+32+16)
33 | |     pub const NftsCollectionBalanceDeposit: Balance = deposit(1, 120);
...  |
41 | |     pub const NftsMaxDeadlineDuration: BlockNumber = 12 * 30 * DAYS;
42 | | }
   | |_^
   |
   = note: this warning originates in the macro `$crate::parameter_types` which comes from the expansion of the macro `parameter_types` (in Nightly builds, run with -Z macro-backtrace for more info)

Check warning on line 265 in /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/frame-support-36.0.0/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a struct

warning: missing documentation for a struct
  --> runtime/testnet/src/config/assets.rs:30:1
   |
30 | / parameter_types! {
31 | |     pub NftsPalletFeatures: PalletFeatures = PalletFeatures::all_enabled();
32 | |     // Key = 68 bytes (4+16+32+16), Value = 52 bytes (4+32+16)
33 | |     pub const NftsCollectionBalanceDeposit: Balance = deposit(1, 120);
...  |
41 | |     pub const NftsMaxDeadlineDuration: BlockNumber = 12 * 30 * DAYS;
42 | | }
   | |_^
   |
   = note: this warning originates in the macro `$crate::parameter_types` which comes from the expansion of the macro `parameter_types` (in Nightly builds, run with -Z macro-backtrace for more info)

Check warning on line 265 in /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/frame-support-36.0.0/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a struct

warning: missing documentation for a struct
  --> runtime/testnet/src/config/assets.rs:30:1
   |
30 | / parameter_types! {
31 | |     pub NftsPalletFeatures: PalletFeatures = PalletFeatures::all_enabled();
32 | |     // Key = 68 bytes (4+16+32+16), Value = 52 bytes (4+32+16)
33 | |     pub const NftsCollectionBalanceDeposit: Balance = deposit(1, 120);
...  |
41 | |     pub const NftsMaxDeadlineDuration: BlockNumber = 12 * 30 * DAYS;
42 | | }
   | |_^
   |
   = note: this warning originates in the macro `$crate::parameter_types` which comes from the expansion of the macro `parameter_types` (in Nightly builds, run with -Z macro-backtrace for more info)

Check warning on line 265 in /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/frame-support-36.0.0/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a struct

warning: missing documentation for a struct
  --> runtime/testnet/src/config/assets.rs:30:1
   |
30 | / parameter_types! {
31 | |     pub NftsPalletFeatures: PalletFeatures = PalletFeatures::all_enabled();
32 | |     // Key = 68 bytes (4+16+32+16), Value = 52 bytes (4+32+16)
33 | |     pub const NftsCollectionBalanceDeposit: Balance = deposit(1, 120);
...  |
41 | |     pub const NftsMaxDeadlineDuration: BlockNumber = 12 * 30 * DAYS;
42 | | }
   | |_^
   |
   = note: this warning originates in the macro `$crate::parameter_types` which comes from the expansion of the macro `parameter_types` (in Nightly builds, run with -Z macro-backtrace for more info)

Check warning on line 265 in /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/frame-support-36.0.0/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a struct

warning: missing documentation for a struct
  --> runtime/testnet/src/config/assets.rs:30:1
   |
30 | / parameter_types! {
31 | |     pub NftsPalletFeatures: PalletFeatures = PalletFeatures::all_enabled();
32 | |     // Key = 68 bytes (4+16+32+16), Value = 52 bytes (4+32+16)
33 | |     pub const NftsCollectionBalanceDeposit: Balance = deposit(1, 120);
...  |
41 | |     pub const NftsMaxDeadlineDuration: BlockNumber = 12 * 30 * DAYS;
42 | | }
   | |_^
   |
   = note: this warning originates in the macro `$crate::parameter_types` which comes from the expansion of the macro `parameter_types` (in Nightly builds, run with -Z macro-backtrace for more info)

Check warning on line 265 in /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/frame-support-36.0.0/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a struct

warning: missing documentation for a struct
  --> runtime/testnet/src/config/assets.rs:30:1
   |
30 | / parameter_types! {
31 | |     pub NftsPalletFeatures: PalletFeatures = PalletFeatures::all_enabled();
32 | |     // Key = 68 bytes (4+16+32+16), Value = 52 bytes (4+32+16)
33 | |     pub const NftsCollectionBalanceDeposit: Balance = deposit(1, 120);
...  |
41 | |     pub const NftsMaxDeadlineDuration: BlockNumber = 12 * 30 * DAYS;
42 | | }
   | |_^
   |
   = note: this warning originates in the macro `$crate::parameter_types` which comes from the expansion of the macro `parameter_types` (in Nightly builds, run with -Z macro-backtrace for more info)

Check warning on line 265 in /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/frame-support-36.0.0/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a struct

warning: missing documentation for a struct
  --> runtime/testnet/src/config/assets.rs:30:1
   |
30 | / parameter_types! {
31 | |     pub NftsPalletFeatures: PalletFeatures = PalletFeatures::all_enabled();
32 | |     // Key = 68 bytes (4+16+32+16), Value = 52 bytes (4+32+16)
33 | |     pub const NftsCollectionBalanceDeposit: Balance = deposit(1, 120);
...  |
41 | |     pub const NftsMaxDeadlineDuration: BlockNumber = 12 * 30 * DAYS;
42 | | }
   | |_^
   |
   = note: this warning originates in the macro `$crate::parameter_types` which comes from the expansion of the macro `parameter_types` (in Nightly builds, run with -Z macro-backtrace for more info)