-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use custom docker image for circlci #112
base: master
Are you sure you want to change the base?
Conversation
There seems to be an error. If the tests are run on circleci, |
What I did (outside the docker) to run the tests on localhost was to run the microdraw server in From the
|
imagehash is used. The test calculates the average hash for every generated image and its reference image. It fails if the difference of the hashes is larger than 10. The values for |
… reference screenshots and generated screenshots
I believe the reason for the failed test is how the existing commit behave when |
this PR... we close it? keep it? merge it? |
Oh wow, a blast from the past. I think using image hash to compare the result is probably more scalable than asking contributors to run test on their machine and check the result manually. I think we can close this for now, but perhaps we can leave an issue? I am hoping that I can get to adapting the code phillip pushed in the new repo. |
Use the custom docker image defined in the Dockerfile for testing