Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow max_cells and min_level to be set by feature #264

Merged
merged 2 commits into from
Jan 7, 2025
Merged

allow max_cells and min_level to be set by feature #264

merged 2 commits into from
Jan 7, 2025

Conversation

edzer
Copy link
Member

@edzer edzer commented Jan 7, 2025

addresses r-spatial/sf#2488

@edzer edzer requested a review from paleolimbot January 7, 2025 14:54
paleolimbot
paleolimbot approved these changes Jan 7, 2025
View reviewed changes
Copy link
Collaborator

@paleolimbot paleolimbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

CI failure seems unrelated (something about guarding examples in if (requireNamespace("vctrs"))?), feel free to merge and I can sort that later 🙂

@edzer edzer merged commit cc2150e into main Jan 7, 2025
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paleolimbot paleolimbot paleolimbot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@edzer @paleolimbot