New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Call `compile_dll()` after `load_code()` #307

Open

t-kalinowski wants to merge 1 commit into r-lib:main from t-kalinowski:load_code-then-compile_dll

Member

t-kalinowski commented Dec 17, 2024

This PR adjusts the sequence of events slightly, moving compile_dll() to just before load_dll(), and after load_code().

The primary motivation is to allow R code to modify files in ./src during a devtools::load_all() call.

The only potentially user-facing change I can think of with this patch is that compilation errors will be signaled a little later.


          call compile_dll() after load_code()

2123c6a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet