Fix find_package_root() for relative paths

Paths that need to be normalized were wrong.
r-lib · Nov 20, 2023 · 5762e2f · 5762e2f
1 parent fd19ffb
commit 5762e2f
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/R/find-package-root.R b/R/find-package-root.R
@@ -9,7 +9,7 @@ find_package_root <- function(path = ".") {
   if (!file.exists(path)) {
     stop("Path does not exist: ", path)
   }
-  cur_path <- path
+  cur_path <- normalizePath(path, winslash = "/")
   errmsg <- paste0(
     "Could not find R package in `",
     path,

diff --git a/tests/testthat/test-find-package-root.R b/tests/testthat/test-find-package-root.R
@@ -23,6 +23,14 @@ test_that("find_package_root", {
     )),
     lns
   )
+
+  wd <- getwd()
+  on.exit(setwd(wd), add = TRUE)
+  setwd(file.path(tmp, "a", "b", "c"))
+  expect_equal(
+    readLines(file.path(find_package_root("."), "DESCRIPTION")),
+    lns
+  )
 })
 
 test_that("find_package_root errors", {