Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fully deprecate anything marked deprecated since 3.0.0 #2284

Merged
merged 24 commits into from
Nov 18, 2023

Conversation

MichaelChirico
Copy link
Collaborator

Note that we can't use lintr_deprecated(signal = "stop") for the removed linters (e.g. closed_curly_linter()) because we test that all linters (under linters_with_tags(exclude_tags = NULL)) can be instantiated. So we have to make a clean removal already.

@codecov-commenter
Copy link

codecov-commenter commented Nov 14, 2023

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (d9b2989) 99.64% compared to head (b8f95eb) 99.44%.

❗ Current head b8f95eb differs from pull request most recent head e5b4a44. Consider uploading reports for the commit e5b4a44 to get more accurate results

Files Patch % Lines
R/lintr-deprecated.R 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2284      +/-   ##
==========================================
- Coverage   99.64%   99.44%   -0.20%     
==========================================
  Files         115      115              
  Lines        5331     5258      -73     
==========================================
- Hits         5312     5229      -83     
- Misses         19       29      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

tests/testthat/test-with.R Outdated Show resolved Hide resolved
tests/testthat/test-lint.R Outdated Show resolved Hide resolved
@AshesITR
Copy link
Collaborator

Re removal of deprecated linters: Can't we rewrite the test somehow to allow for hard deprecations? Maybe a special tag "defunct", or logic that tests missing linters for hard-deprecation and allows them not to appear in linters.csv?
Seems a bit harsh to skip from warning to removal.

@MichaelChirico
Copy link
Collaborator Author

Maybe a special tag "defunct"

That SGTM.

R/lintr-deprecated.R Outdated Show resolved Hide resolved
@AshesITR
Copy link
Collaborator

CRAN is down ATM 👀

R/linter_tags.R Outdated Show resolved Hide resolved
R/lintr-deprecated.R Outdated Show resolved Hide resolved
@MichaelChirico
Copy link
Collaborator Author

CRAN is down ATM 👀

Noting here as well my ref from #2289 for completeness:


Yes, CRAN is undergoing scheduled maintenance:

https://bsky.app/profile/eddelbuettel.com/post/3keb4kxyzpj2v

AshesITR
AshesITR previously approved these changes Nov 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants