-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fully deprecate anything marked deprecated since 3.0.0 #2284
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2284 +/- ##
==========================================
- Coverage 99.64% 99.44% -0.20%
==========================================
Files 115 115
Lines 5331 5258 -73
==========================================
- Hits 5312 5229 -83
- Misses 19 29 +10 ☔ View full report in Codecov by Sentry. |
Re removal of deprecated linters: Can't we rewrite the test somehow to allow for hard deprecations? Maybe a special tag "defunct", or logic that tests missing linters for hard-deprecation and allows them not to appear in linters.csv? |
That SGTM. |
CRAN is down ATM 👀 |
Noting here as well my ref from #2289 for completeness: Yes, CRAN is undergoing scheduled maintenance: https://bsky.app/profile/eddelbuettel.com/post/3keb4kxyzpj2v |
Note that we can't use
lintr_deprecated(signal = "stop")
for the removed linters (e.g.closed_curly_linter()
) because we test that all linters (underlinters_with_tags(exclude_tags = NULL)
) can be instantiated. So we have to make a clean removal already.