Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename no_tab_linter to whitespace_linter #1955

Merged
merged 7 commits into from
Apr 9, 2023
Merged

Conversation

MichaelChirico
Copy link
Collaborator

Closes #1954

@codecov-commenter
Copy link

codecov-commenter commented Apr 7, 2023

Codecov Report

Merging #1955 (e0b64f3) into main (fb294cc) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head e0b64f3 differs from pull request most recent head 34efc8a. Consider uploading reports for the commit 34efc8a to get more accurate results

@@           Coverage Diff           @@
##             main    #1955   +/-   ##
=======================================
  Coverage   98.95%   98.95%           
=======================================
  Files         113      113           
  Lines        4966     4972    +6     
=======================================
+ Hits         4914     4920    +6     
  Misses         52       52           
Impacted Files Coverage Δ
R/lintr-deprecated.R 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Collaborator

@AshesITR AshesITR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure whether we should explicitly state future planned development in the docs.

@MichaelChirico
Copy link
Collaborator Author

Not sure whether we should explicitly state future planned development in the docs.

Do you mean in NEWS? In ?whitespace_linter, we have "Currently, only supports linting in the presence of tabs." which hints at something being done later but gives no specifics/commitments. I think that's OK; submitting for now but feel free to follow-up

@MichaelChirico MichaelChirico merged commit b233d7a into main Apr 9, 2023
@MichaelChirico MichaelChirico deleted the whitespace-linter branch April 9, 2023 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename no_tabs_linter() to whitespace_linter()
3 participants