New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Guard uses of `get_p()` against `R_NilValue` #388

Merged

DavisVaughan merged 2 commits into r-lib:main from DavisVaughan:fix/guard-against-null-in-get-p

Aug 21, 2024

Member

DavisVaughan commented Aug 21, 2024

Found when looking at marquee failures

I don't think it makes sense to put this in get_p() itself. Many times we use get_p() but we know the data is not R_NilValue already.

DavisVaughan added 2 commits

August 21, 2024 17:41


          Add failing tests

e2362a2


          Guard two uses of get_p() against R_NilValue

bfb4a9b

DavisVaughan merged commit 8c5bfd3 into r-lib:main

16 checks passed

DavisVaughan deleted the fix/guard-against-null-in-get-p branch

August 21, 2024 21:54

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet