Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vendoring #341

Closed
wants to merge 11 commits into from
Closed

Vendoring #341

wants to merge 11 commits into from

Conversation

pachadotdev
Copy link
Contributor

#340 but without the breaking changes

This was referenced Nov 10, 2023
@pachadotdev
Copy link
Contributor Author

@krlmlr hi, this allows u to vendor to src/vendor!
@hadley i keep the unlink() function in vendor.R examples to pass the local check(), but that then creates problems with pkgdown

@krlmlr
Copy link
Member

krlmlr commented Jan 31, 2024

Thanks. I'd wait for a comment on if we want to vendor into src/vendor at all. Perhaps there's a reason for vendoring into inst/include ?

@pachadotdev
Copy link
Contributor Author

Thanks. I'd wait for a comment on if we want to vendor into src/vendor at all. Perhaps there's a reason for vendoring into inst/include ?

what i saw with check(), is that it doesn't like to put files in src, but if i vendor in src/vendor in a pkg project, it passes all checks for that another pkg

@krlmlr
Copy link
Member

krlmlr commented Jan 31, 2024

  • The checks in this PR are failing
  • This PR seems to have a bit of noise
  • We don't know the maintainers' perspective on if this PR is a good, so I'm not sure if it's worth addressing the first two issues at all

Let's not spend too much time here for now?

@pachadotdev
Copy link
Contributor Author

  • The checks in this PR are failing

    • This PR seems to have a bit of noise

    • We don't know the maintainers' perspective on if this PR is a good, so I'm not sure if it's worth addressing the first two issues at all

Let's not spend too much time here for now?

sure, i was following from the vendoring in https://github.com/r-dbi/RPostgres/tree/main/src/vendor/boost

@pachadotdev pachadotdev deleted the vendoring branch February 16, 2024 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants