-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding nameof utility function #256
Open
bkietz
wants to merge
2
commits into
r-lib:main
Choose a base branch
from
bkietz:add-nameof-utility
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
#include "cpp11/nameof.hpp" | ||
|
||
#include <testthat.h> | ||
|
||
struct Global; | ||
|
||
namespace ns { | ||
struct Namespaced; | ||
} // namespace ns | ||
|
||
context("nameof-C++") { | ||
test_that("nameof works") { | ||
expect_true(cpp11::nameof<Global>() == "Global"); | ||
expect_true(cpp11::nameof<ns::Namespaced>() == "ns::Namespaced"); | ||
expect_true(cpp11::nameof<ns::Namespaced>(/*strip_namespace=*/true) == "Namespaced"); | ||
|
||
// namespace for local scope structs is compiler dependent | ||
struct Local; | ||
expect_true(cpp11::nameof<Local>(/*strip_namespace=*/true) == "Local"); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,82 @@ | ||
/// Distributed under the Boost Software License, Version 1.0. (See | ||
/// http://www.boost.org/LICENSE_1_0.txt) | ||
|
||
#include <array> | ||
#include <string> | ||
#include <tuple> | ||
#include <utility> | ||
|
||
namespace cpp11 { | ||
namespace detail { | ||
|
||
#ifdef _MSC_VER | ||
#define ARROW_PRETTY_FUNCTION __FUNCSIG__ | ||
#else | ||
#define ARROW_PRETTY_FUNCTION __PRETTY_FUNCTION__ | ||
#endif | ||
|
||
template <typename T> | ||
const char* raw() { | ||
return ARROW_PRETTY_FUNCTION; | ||
} | ||
|
||
template <typename T> | ||
size_t raw_sizeof() { | ||
return sizeof(ARROW_PRETTY_FUNCTION); | ||
} | ||
|
||
#undef ARROW_PRETTY_FUNCTION | ||
|
||
constexpr bool starts_with(char const* haystack, char const* needle) { | ||
return needle[0] == '\0' || | ||
(haystack[0] == needle[0] && starts_with(haystack + 1, needle + 1)); | ||
} | ||
|
||
constexpr size_t search(char const* haystack, char const* needle) { | ||
return haystack[0] == '\0' || starts_with(haystack, needle) | ||
? 0 | ||
: search(haystack + 1, needle) + 1; | ||
} | ||
|
||
const size_t typename_prefix = search(raw<double>(), "double"); | ||
|
||
template <typename T> | ||
size_t struct_class_prefix() { | ||
#ifdef _MSC_VER | ||
return starts_with(raw<T>() + typename_prefix, "struct ") | ||
? 7 | ||
: starts_with(raw<T>() + typename_prefix, "class ") ? 6 : 0; | ||
#else | ||
return 0; | ||
#endif | ||
} | ||
|
||
template <typename T> | ||
size_t typename_length() { | ||
// raw_sizeof<T>() - raw_sizeof<double>() == | ||
// (length of T's name) - strlen("double") | ||
// (length of T's name) == | ||
// raw_sizeof<T>() - raw_sizeof<double>() + strlen("double") | ||
return raw_sizeof<T>() - struct_class_prefix<T>() - raw_sizeof<double>() + 6; | ||
} | ||
|
||
template <typename T> | ||
const char* typename_begin() { | ||
return raw<T>() + struct_class_prefix<T>() + typename_prefix; | ||
} | ||
|
||
} // namespace detail | ||
|
||
template <typename T> | ||
std::string nameof(bool strip_namespace = false) { | ||
std::string name{detail::typename_begin<T>(), detail::typename_length<T>()}; | ||
if (strip_namespace) { | ||
auto i = name.find_last_of("::"); | ||
if (i != std::string::npos) { | ||
name = name.substr(i + 1); | ||
} | ||
} | ||
return name; | ||
} | ||
|
||
} // namespace cpp11 |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this copied from a boost library ? Should this be acknowledged in the
DESCRIPTION
file ?