Remove usage of coord_flip() (#147)

* Require tidyr 1.0.0 everywhere

* coord_flip() is superseded since ggplot2 3.3

R/autoplot.R

@@ -51,7 +51,7 @@ autoplot.bench_mark <- function(
   type = c("beeswarm", "jitter", "ridge", "boxplot", "violin"),
   ...
 ) {
-  rlang::check_installed(c("ggplot2", "tidyr"), "for `autoplot()`.")
+  rlang::check_installed(c("ggplot2", "tidyr (>= 1.0.0)"), "for `autoplot()`.")
 
   type <- match.arg(type)
 
@@ -64,38 +64,30 @@ autoplot.bench_mark <- function(
     object$expression <- as.character(object$expression)
   }
 
-  if (tidyr_new_interface()) {
-    res <- tidyr::unnest(object, c(time, gc))
-  } else {
-    res <- tidyr::unnest(object)
-  }
+  res <- tidyr::unnest(object, c(time, gc))
   p <- ggplot2::ggplot(res)
 
   switch(
     type,
     beeswarm = p <- p +
-      ggplot2::aes(.data$expression, .data$time, color = .data$gc) +
-      ggbeeswarm::geom_quasirandom(...) +
-      ggplot2::coord_flip(),
+      ggplot2::aes(.data$time, .data$expression, color = .data$gc) +
+      ggbeeswarm::geom_quasirandom(..., orientation = "y"),
 
     jitter = p <- p +
-      ggplot2::aes(.data$expression, .data$time, color = .data$gc) +
-      ggplot2::geom_jitter(...) +
-      ggplot2::coord_flip(),
+      ggplot2::aes(.data$time, .data$expression, color = .data$gc) +
+      ggplot2::geom_jitter(...),
 
     ridge = p <- p +
       ggplot2::aes(.data$time, .data$expression) +
       ggridges::geom_density_ridges(...),
 
     boxplot = p <- p +
-      ggplot2::aes(.data$expression, .data$time) +
-      ggplot2::geom_boxplot(...) +
-      ggplot2::coord_flip(),
+      ggplot2::aes(.data$time, .data$expression) +
+      ggplot2::geom_boxplot(...),
 
     violin = p <- p +
-      ggplot2::aes(.data$expression, .data$time) +
-      ggplot2::geom_violin(...) +
-      ggplot2::coord_flip()
+      ggplot2::aes(.data$time, .data$expression) +
+      ggplot2::geom_violin(...)
   )
 
   parameters <- setdiff(

R/mark.R

@@ -400,13 +400,7 @@ unnest.bench_mark <- function(data, ...) {
 
   # suppressWarnings to avoid 'elements may not preserve their attributes'
   # warnings from dplyr::collapse
-  if (tidyr_new_interface()) {
-    data <- suppressWarnings(NextMethod(.Generic, data, ...))
-  } else {
-    data <- suppressWarnings(
-      NextMethod(.Generic, data, time, gc, .drop = FALSE)
-    )
-  }
+  data <- suppressWarnings(NextMethod(.Generic, data, ...))
 
   # Add bench_time class back to the time column
   data$time <- as_bench_time(data$time)

R/utils.R

@@ -102,11 +102,6 @@ lengths <- function(x, use.names = TRUE) {
   viapply(x, length, USE.NAMES = use.names)
 }
 
-# check if the new interface is being used
-tidyr_new_interface <- function() {
-  utils::packageVersion("tidyr") > "0.8.99"
-}
-
 dots <- function(...) {
   dots <- as.list(substitute(...()))
 

tests/testthat/test-mark.R

@@ -301,13 +301,9 @@ describe("summary.bench_mark", {
 
 describe("unnest.bench_mark", {
   it("does not contain result or memory columns", {
-    skip_if_not_installed("tidyr")
+    skip_if_not_installed("tidyr", "1.0.0")
     bnch <- mark(1 + 1, 2 + 0)
-    if (tidyr_new_interface()) {
-      res <- tidyr::unnest(bnch, c(time, gc))
-    } else {
-      res <- tidyr::unnest(bnch)
-    }
+    res <- tidyr::unnest(bnch, c(time, gc))
 
     gc_cols <- colnames(bnch$gc[[1]])