Skip to content

Commit

Permalink
Allow File share creation with Access key with default false (microso…
Browse files Browse the repository at this point in the history
…ft#3449)

* Update features.py

add param for allow_shared_key_access as default off to definition "create_file_share". This will allow creating SMB shares with Access key ( currently ) for XFStesting.
We should ideally move to ADDS based authentication for SMB mount for the purpose of XFStesting SMB in the near future

* Update features.py

removed empty line at 2721

* Update features.py

* Update features.py

* Update features.py

* Update features.py
  • Loading branch information
shekharsorot authored Sep 30, 2024
1 parent 96ff777 commit 537663b
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion lisa/sut_orchestrator/azure/features.py
Original file line number Diff line number Diff line change
Expand Up @@ -3233,7 +3233,10 @@ def _initialize_fileshare_information(self) -> None:
)

def create_file_share(
self, file_share_names: List[str], environment: Environment
self,
file_share_names: List[str],
environment: Environment,
allow_shared_key_access: bool = False,
) -> Dict[str, str]:
platform: AzurePlatform = self._platform # type: ignore
information = environment.get_information()
Expand All @@ -3251,6 +3254,7 @@ def create_file_share(
resource_group_name=resource_group_name,
location=location,
log=self._log,
allow_shared_key_access=allow_shared_key_access,
)

for share_name in file_share_names:
Expand Down

0 comments on commit 537663b

Please sign in to comment.