Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

specify go version in Dockerfile #747

Merged
merged 1 commit into from
Mar 19, 2024
Merged

specify go version in Dockerfile #747

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion scaling-acceptance-tests.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -366,7 +366,9 @@ Try and run the test.
We need to create a Dockerfile for our program. Inside our `httpserver` folder, create a `Dockerfile` and add the following.

```dockerfile
FROM golang:1.18-alpine
# Make sure to specify the same Go version as the one in the go.mod file.
# For example, golang:1.22.1-alpine.
FROM golang:1.18-alpine

WORKDIR /app

Expand Down Expand Up @@ -968,6 +970,7 @@ If you run again, it should now _compile_ but not pass because we haven't create
Create a new `Dockerfile` inside `cmd/grpcserver`.

```dockerfile
# Make sure to specify the same Go version as the one in the go.mod file.
FROM golang:1.18-alpine

WORKDIR /app
Expand Down Expand Up @@ -1263,6 +1266,7 @@ You've probably noticed the two `Dockerfiles` are almost identical beyond the pa
`Dockerfiles` can accept arguments to let us reuse them in different contexts, which sounds perfect. We can delete our 2 Dockerfiles and instead have one at the root of the project with the following

```dockerfile
# Make sure to specify the same Go version as the one in the go.mod file.
FROM golang:1.18-alpine

WORKDIR /app
Expand Down
Loading