Sample cluster state from peer seeds #124
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guilload
commented
Feb 20, 2024
| .await?; | ||
|
|
||
| let mut seed_addrs: Vec<SocketAddr> = self.cluster_state.seed_addrs().into_iter().collect(); | ||
| seed_addrs.shuffle(&mut rand::thread_rng()); |
There was a problem hiding this comment.
If the seeds are empty, we could try from self. WDYT?
Comment on lines
+402
to
+409
| let node_state = self.cluster_state.node_state_mut(chitchat_id); | ||
|
|
||
| for (key, value) in key_values { |
There was a problem hiding this comment.
Suggested change
| let node_state = self.cluster_state.node_state_mut(chitchat_id); | |
| for (key, value) in key_values { | |
| let node_state = self.cluster_state.node_state_mut(chitchat_id); | |
| if node_state.hearbeat == 0 { | |
| self.failure_detector.report_heartbeat(chitchat_id)? | |
| } | |
| for (key, value) in key_values { |
report_unknown no longer exists. Would that work?
| } | ||
|
|
||
| impl VersionedValue { | ||
| pub fn new(value: String, version: Version, is_tombstone: bool) -> VersionedValue { |
guilload
force-pushed
the
guilload/sample-message
branch
3 times, most recently
from
31d92bd to
7454650
Compare
guilload
force-pushed
the
guilload/sample-message
branch
from
7454650 to
d461963
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea is to allow fetching a few attributes (readiness, gRPC advertise address) from the peer seeds using
sample_from_seedsto then download the cluster state directly via gRPC calls, and finally bootstrap our own state usinginsert_or_create_node.