Skip to content

Change in the liveness detection. #289

Change in the liveness detection.

Change in the liveness detection. #289

Triggered via pull request February 15, 2024 12:05
Status Failure
Total duration 1m 49s
Artifacts

ci.yml

on: pull_request
Check (fmt, dependency check, clippy, test)
1m 39s
Check (fmt, dependency check, clippy, test)
Fit to window
Zoom out
Zoom in

Annotations

7 errors and 2 warnings
this expression creates a reference which is immediately dereferenced by the compiler: chitchat/src/lib.rs#L176
error: this expression creates a reference which is immediately dereferenced by the compiler --> chitchat/src/lib.rs:176:52 | 176 | self.failure_detector.report_heartbeat(&chitchat_id); | ^^^^^^^^^^^^ help: change this to: `chitchat_id` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
this expression creates a reference which is immediately dereferenced by the compiler: chitchat/src/lib.rs#L101
error: this expression creates a reference which is immediately dereferenced by the compiler --> chitchat/src/lib.rs:101:35 | 101 | self.report_heartbeat(&chitchat_id, node_digest.heartbeat); | ^^^^^^^^^^^^ help: change this to: `chitchat_id` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow = note: `-D clippy::needless-borrow` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::needless_borrow)]`
this expression creates a reference which is immediately dereferenced by the compiler: chitchat/src/lib.rs#L176
error: this expression creates a reference which is immediately dereferenced by the compiler --> chitchat/src/lib.rs:176:52 | 176 | self.failure_detector.report_heartbeat(&chitchat_id); | ^^^^^^^^^^^^ help: change this to: `chitchat_id` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
this expression creates a reference which is immediately dereferenced by the compiler: chitchat/src/lib.rs#L101
error: this expression creates a reference which is immediately dereferenced by the compiler --> chitchat/src/lib.rs:101:35 | 101 | self.report_heartbeat(&chitchat_id, node_digest.heartbeat); | ^^^^^^^^^^^^ help: change this to: `chitchat_id` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow = note: `-D clippy::needless-borrow` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::needless_borrow)]`
manual implementation of an assign operation: chitchat/src/failure_detector.rs#L269
error: manual implementation of an assign operation --> chitchat/src/failure_detector.rs:269:9 | 269 | self.index = self.index + 1; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.index += 1` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern = note: `-D clippy::assign-op-pattern` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::assign_op_pattern)]`
manual implementation of an assign operation: chitchat/src/failure_detector.rs#L269
error: manual implementation of an assign operation --> chitchat/src/failure_detector.rs:269:9 | 269 | self.index = self.index + 1; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.index += 1` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern = note: `-D clippy::assign-op-pattern` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::assign_op_pattern)]`
Check (fmt, dependency check, clippy, test)
Clippy had exited with the 101 exit code
Check (fmt, dependency check, clippy, test)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/cache@v2, actions-rs/clippy-check@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Check (fmt, dependency check, clippy, test)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/cache@v2, actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/