Adding compression [WIP] #248
ci.yml
on: pull_request
Check (fmt, dependency check, clippy, test)
1m 1s
Annotations
16 errors and 2 warnings
casting to the same type is unnecessary (`usize` -> `usize`):
chitchat/src/serialize.rs#L417
error: casting to the same type is unnecessary (`usize` -> `usize`)
--> chitchat/src/serialize.rs:417:33
|
417 | buf.advance(len as usize);
| ^^^^^^^^^^^^ help: try: `len`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
|
casting to the same type is unnecessary (`usize` -> `usize`):
chitchat/src/serialize.rs#L407
error: casting to the same type is unnecessary (`usize` -> `usize`)
--> chitchat/src/serialize.rs:407:33
|
407 | buf.advance(len as usize);
| ^^^^^^^^^^^^ help: try: `len`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
= note: `-D clippy::unnecessary-cast` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::unnecessary_cast)]`
|
method `serialized_len_upperbound_after` is never used:
chitchat/src/serialize.rs#L325
error: method `serialized_len_upperbound_after` is never used
--> chitchat/src/serialize.rs:325:12
|
310 | impl<S: Serializable> CompressedStreamWriter<S> {
| ----------------------------------------------- method in this implementation
...
325 | pub fn serialized_len_upperbound_after(&self, item: &S) -> usize {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
variants `Node`, `KeyValue`, and `NodesToReset` are never constructed:
chitchat/src/delta.rs#L56
error: variants `Node`, `KeyValue`, and `NodesToReset` are never constructed
--> chitchat/src/delta.rs:56:5
|
55 | enum DeltaOpRef<'a> {
| ---------- variants in this enum
56 | Node(&'a ChitchatId),
| ^^^^
57 | KeyValue {
| ^^^^^^^^
...
61 | NodesToReset(&'a ChitchatId),
| ^^^^^^^^^^^^
|
fields `key` and `versioned_value` are never read:
chitchat/src/delta.rs#L16
error: fields `key` and `versioned_value` are never read
--> chitchat/src/delta.rs:16:9
|
15 | KeyValue {
| -------- fields in this variant
16 | key: String,
| ^^^
17 | versioned_value: VersionedValue,
| ^^^^^^^^^^^^^^^
|
= note: `-D dead-code` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(dead_code)]`
|
casting to the same type is unnecessary (`usize` -> `usize`):
chitchat/src/serialize.rs#L417
error: casting to the same type is unnecessary (`usize` -> `usize`)
--> chitchat/src/serialize.rs:417:33
|
417 | buf.advance(len as usize);
| ^^^^^^^^^^^^ help: try: `len`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
|
casting to the same type is unnecessary (`usize` -> `usize`):
chitchat/src/serialize.rs#L407
error: casting to the same type is unnecessary (`usize` -> `usize`)
--> chitchat/src/serialize.rs:407:33
|
407 | buf.advance(len as usize);
| ^^^^^^^^^^^^ help: try: `len`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
= note: `-D clippy::unnecessary-cast` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::unnecessary_cast)]`
|
unused variable: `compressed_len_u16`:
chitchat/src/serialize.rs#L361
error: unused variable: `compressed_len_u16`
--> chitchat/src/serialize.rs:361:21
|
361 | let compressed_len_u16 = u16::try_from(compressed_len).unwrap();
| ^^^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_compressed_len_u16`
|
= note: `-D unused-variables` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(unused_variables)]`
|
associated items `with_block_threshold`, `serialized_len_upperbound_after`, `append`, `flush_block`, and `finalize` are never used:
chitchat/src/serialize.rs#L311
error: associated items `with_block_threshold`, `serialized_len_upperbound_after`, `append`, `flush_block`, and `finalize` are never used
--> chitchat/src/serialize.rs:311:12
|
310 | impl<S: Serializable> CompressedStreamWriter<S> {
| ----------------------------------------------- associated items in this implementation
311 | pub fn with_block_threshold(block_threshold: u16) -> CompressedStreamWriter<S> {
| ^^^^^^^^^^^^^^^^^^^^
...
325 | pub fn serialized_len_upperbound_after(&self, item: &S) -> usize {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
...
334 | pub fn append(&mut self, item: S) {
| ^^^^^^
...
347 | fn flush_block(&mut self) {
| ^^^^^^^^^^^
...
383 | pub fn finalize(mut self) -> Vec<u8> {
| ^^^^^^^^
|
struct `CompressedStreamWriter` is never constructed:
chitchat/src/serialize.rs#L297
error: struct `CompressedStreamWriter` is never constructed
--> chitchat/src/serialize.rs:297:12
|
297 | pub struct CompressedStreamWriter<S: Serializable> {
| ^^^^^^^^^^^^^^^^^^^^^^
|
variants `Node`, `KeyValue`, and `NodesToReset` are never constructed:
chitchat/src/delta.rs#L56
error: variants `Node`, `KeyValue`, and `NodesToReset` are never constructed
--> chitchat/src/delta.rs:56:5
|
55 | enum DeltaOpRef<'a> {
| ---------- variants in this enum
56 | Node(&'a ChitchatId),
| ^^^^
57 | KeyValue {
| ^^^^^^^^
...
61 | NodesToReset(&'a ChitchatId),
| ^^^^^^^^^^^^
|
fields `key` and `versioned_value` are never read:
chitchat/src/delta.rs#L16
error: fields `key` and `versioned_value` are never read
--> chitchat/src/delta.rs:16:9
|
15 | KeyValue {
| -------- fields in this variant
16 | key: String,
| ^^^
17 | versioned_value: VersionedValue,
| ^^^^^^^^^^^^^^^
|
= note: `-D dead-code` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(dead_code)]`
|
unused variable: `compressed_len_u16`:
chitchat/src/serialize.rs#L361
error: unused variable: `compressed_len_u16`
--> chitchat/src/serialize.rs:361:21
|
361 | let compressed_len_u16 = u16::try_from(compressed_len).unwrap();
| ^^^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_compressed_len_u16`
|
= note: `-D unused-variables` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(unused_variables)]`
|
this import is redundant:
chitchat/src/serialize.rs#L7
error: this import is redundant
--> chitchat/src/serialize.rs:7:1
|
7 | use zstd;
| ^^^^^^^^^ help: remove it entirely
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports
= note: `-D clippy::single-component-path-imports` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::single_component_path_imports)]`
|
this import is redundant:
chitchat/src/serialize.rs#L7
error: this import is redundant
--> chitchat/src/serialize.rs:7:1
|
7 | use zstd;
| ^^^^^^^^^ help: remove it entirely
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports
= note: `-D clippy::single-component-path-imports` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::single_component_path_imports)]`
|
Check (fmt, dependency check, clippy, test)
Clippy had exited with the 101 exit code
|
Check (fmt, dependency check, clippy, test)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/cache@v2, actions-rs/clippy-check@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
Check (fmt, dependency check, clippy, test)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/cache@v2, actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|