Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(QInput, QChipsInput, QUploader): Add custom loading slot as QBtn #2506

Merged
merged 1 commit into from
Sep 17, 2018

Conversation

jcperez-ch
Copy link
Contributor

@jcperez-ch jcperez-ch commented Sep 1, 2018

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • It's submitted to the dev branch and not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • It's been tested with all Quasar themes
  • It's been tested on a Cordova (iOS, Android) app
  • It's been tested on a Electron app
  • Any necessary documentation has been added or updated in the docs (for faster update click on "Suggest an edit on GitHub" at bottom of page) or explained in the PR's description.

quasarframework/quasar-framework.org#586

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

This PR introduces the loading slot to components:

  • QInput
  • QChipsInput
  • QUploader

It emulates the behaviour of QBtn of having a custom UI that indicates that the component is loading instead of the default theme QSpinner. This keeps consistency of spinners when using custom QSpinner.* or any other way to indicate loading states.

@jcperez-ch
Copy link
Contributor Author

Hi, Is there a plan to review this PR soon? Thanks

@rstoenescu rstoenescu added this to the v0.17.15 milestone Sep 17, 2018
@rstoenescu rstoenescu merged commit 0e253cc into quasarframework:dev Sep 17, 2018
@rstoenescu
Copy link
Member

Thank you for taking time for this PR! It will go into Quasar v0.17.15 shortly.

@jcperez-ch
Copy link
Contributor Author

Hi @rstoenescu did you see the Docs PR as well? quasarframework/quasar-framework.org#586

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants