-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update embedded-nal to 0.9 #166
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution!
- Changelog entry regarding the NAL API bump
- Changelog entry about the MSRV change implied
Do you plan on porting https://github.com/quartiq/smoltcp-nal as well?
I added changelog note about |
By the way, smlang-rs is 0.6.0 in this project, but at 0.7.0 they made But |
If this is a requirement for merging this then yes. |
|
link: quartiq/smoltcp-nal#52 |
Is this PR waiting for something? |
It needs to pass CI checks. |
Added fmt commit |
There is that dev dependency:
And it probably needs to be updated before this PR, I guess. What do you think? |
I figured out some fork was used, while upstream already has support for embeddel_nal 0.9, so I just removed git dependency and used crates.io version |
Fixed doc tets |
Thanks! |
No description provided.