Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update embedded-nal to 0.9 #166

Merged
merged 7 commits into from
Jan 16, 2025
Merged

feat: update embedded-nal to 0.9 #166

merged 7 commits into from
Jan 16, 2025

Conversation

Ddystopia
Copy link
Contributor

No description provided.

Copy link
Member

@jordens jordens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

  • Changelog entry regarding the NAL API bump
  • Changelog entry about the MSRV change implied

Do you plan on porting https://github.com/quartiq/smoltcp-nal as well?

@Ddystopia
Copy link
Contributor Author

I added changelog note about embedded-nal. Not sure what should I do about MSRV, as I can't find any previous mentions of it in this crate.

@Ddystopia
Copy link
Contributor Author

Ddystopia commented Jan 6, 2025

By the way, smlang-rs is 0.6.0 in this project, but at 0.7.0 they made StateMachine::new and StateMachine::new_with_state const functions. This will allow Minimq::new become const too, as the rest of ecosystem has it's constructors. Current vertion om smlang is 0.8.0.

But smlang had breaking changes so it may not be worth it.

@Ddystopia
Copy link
Contributor Author

Do you plan on porting https://github.com/quartiq/smoltcp-nal as well?

If this is a requirement for merging this then yes.

@jordens
Copy link
Member

jordens commented Jan 7, 2025

  • Could you add a changelog entry about the minimum required rust version due to ip-in-core?
  • Feel free to bump smlang in another PR and make the constructor const! PR appreciated. We use 0.8 downstream in miniconf as well.
  • The smoltcp-nal bump isn't required but appreciated as currently it's probably one of the most prominent downstream crates.

@Ddystopia
Copy link
Contributor Author

link: quartiq/smoltcp-nal#52

@Ddystopia Ddystopia requested a review from jordens January 12, 2025 13:17
@Ddystopia
Copy link
Contributor Author

Is this PR waiting for something?

@jordens
Copy link
Member

jordens commented Jan 13, 2025

It needs to pass CI checks.

@Ddystopia
Copy link
Contributor Author

Added fmt commit

@Ddystopia
Copy link
Contributor Author

There is that dev dependency:

std-embedded-nal = { git = "https://gitlab.com/ryan-summers/std-embedded-nal", branch = "feature/0.8" }

And it probably needs to be updated before this PR, I guess. What do you think?

@Ddystopia
Copy link
Contributor Author

I figured out some fork was used, while upstream already has support for embeddel_nal 0.9, so I just removed git dependency and used crates.io version

@Ddystopia
Copy link
Contributor Author

Fixed doc tets

@jordens jordens merged commit 1c93e19 into quartiq:master Jan 16, 2025
7 checks passed
@jordens
Copy link
Member

jordens commented Jan 16, 2025

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants