WIP: esp-qcom-image: convert to OE-core uki.bbclass #722
+26
−135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koenkooi
requested review from
quic-vkraleti,
ricardosalveti,
sbanerjee-quic and
ndechesne
as code owners
|
See qualcomm-linux/meta-qcom-hwe#138 for review and comment history |
koenkooi
force-pushed
the
koen/UKI
branch
2 times, most recently
from
11851e3 to
4f01b2b
Compare
ndechesne
reviewed
Jan 30, 2025
|
|
||
| # Optional subfolder, dependant on where the ESP partition gets mounted | ||
| # intended to only have a leading slash, no trailing slash e.g. '/EFI', or just empty, '' | ||
| ESPFOLDER ?= "/EFI" |
There was a problem hiding this comment.
in which case/scenario are we expected to use ESPFOLDER? is that really needed?
There was a problem hiding this comment.
It should be somthing like /boot/efi by default
There was a problem hiding this comment.
For non-qcom systems the ESP can be mounted in different places, e.g. /boot/efi/, in our case it's mounted directly as /boot, hence "EFI" being in the root.
|
|
||
| UKI_CMDLINE="root=${QCOM_BOOTIMG_ROOTFS} rw rootwait" | ||
|
|
||
| # Remove leading 'qcom/' from KERNEL_DEVICEREE, we store the file in DEPLOY_DIR_IMAGE directly, not in the qcom/ subfolder |
There was a problem hiding this comment.
do we need to keep these 2 lines here?
There was a problem hiding this comment.
The bottom one can go for sure, the top on is still needed AFAICT.
This class uses the OE-core uki.bbclass infrastructure to assemble an ESP image with systemd-boot + UKI. Systemd-boot is installed through package management, the UKI is picked up from deploy. Signed-off-by: Koen Kooi <[email protected]>
Signed-off-by: Koen Kooi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This new class uses the OE-core uki.bbclass infrastructure to assemble an
ESP image with systemd-boot + UKI. It uses method #2 for config-less booting.
Systemd-boot is installed through package management, the UKI is picked
up from deploy.
Signed-off-by: Koen Kooi [email protected]
Fixes #707