Normalize the rotation before syncing #7
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n3vu0r
reviewed
Mar 6, 2024
| @@ -138,7 +138,7 @@ pub fn trackball_camera( | |||
| .unwrap_or(trackball.frame); | |||
| let view = trackball.old_frame.view(); | |||
| transform.translation = view.translation.into(); | |||
| transform.rotation = view.rotation.into(); | |||
| transform.rotation = view.rotation.normalize().into(); | |||
There was a problem hiding this comment.
I would instead normalize the trackball.old_frame after line 135 by appending:
.map(|mut frame| {
frame.renormalize();
frame
})In this way, the de-normalization doesn't add-up in the first place as part of the smoothing.
The final snap-in assignment in line 138 shouldn't cause any trouble as trackball.frame is already re-normalized in:
bevy_trackball/src/constellation.rs
Line 75 in f8264b4
|
Good catch, thanks! |
|
This would be definitely better. I will the PR then and let you implement your suggestion. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After enabling the new feature
debug_glam_assertin Bevy (which is forwarded toglam), my program panics when I rotate with the trackball. I traced it back to the syncing with the Bevy transform.