Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to new-note-namer, to underline the heading instead of highlighting it with # #249

Merged
merged 5 commits into from
Nov 28, 2024
Merged

Add option to new-note-namer, to underline the heading instead of highlighting it with # #249

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d67df29
Added toggle to underline the created heading, instead of highlightin…
Mystechry Nov 28, 2024
67e1b2b
Updated info.json
Mystechry Nov 28, 2024
245ce3a
Update new-note-namer.qml
Mystechry Nov 28, 2024
95283ed
Properly updated the 'authors' array in info.json
Mystechry Nov 28, 2024
03b91a7
Fixed bad spacing
Mystechry Nov 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions new-note-namer/info.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@
"name": "New note namer",
"identifier": "new-note-namer",
"script": "new-note-namer.qml",
"authors": ["@diegovskytl"],
"authors": ["@diegovskytl,@Mystechry"],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use " for strings, and add a space before the string.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

"platforms": ["linux", "macos", "windows"],
"version": "0.0.1",
"version": "0.0.2",
"minAppVersion": "17.06.2",
"description": "Enables a dialog window (or two) so the user can choose the note title and file name at the moment of creation. <br> Specially useful when the 'Allow note file name to be different to note title. \n No more cumbersome renaming :)"
}
14 changes: 13 additions & 1 deletion new-note-namer/new-note-namer.qml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import QOwnNotesTypes 1.0
*/
QtObject {
property bool extraDialogForFileName;
property bool underlineHeading;
property variant settingsVariables: [
{
'identifier': 'extraDialogForFileName',
Expand All @@ -16,6 +17,13 @@ QtObject {
'type': 'boolean',
'default': 'false',
},
{
'identifier': 'underlineHeading',
'name': 'Underline heading',
'description': 'Highlight the first line by underlining it with =, if not checked, use a preceding # instead.',
'type': 'boolean',
'default': 'false',
},
];

function init() {
Expand All @@ -41,7 +49,11 @@ QtObject {
script.log(note.fileCreated)
script.log(note.fileLastModified)

return "# " + newName;
if (underlineHeading){
Copy link
Member

@pbek pbek Nov 28, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a space, like ) {.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

return newName + "\n========================"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't you rather want to count how many = you need according to the name?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is a great idea. The updated file contains that feature.

} else {
return "# " + newName;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please adapt the amount of whitespace?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed my portion of the code. The original script is not properly consistent with its use of whitespace in the first place. Please let me know if I shall unify the whitespacing throughout the whole script.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The whole script is a mess, you are right. Please do so in another PR.

}
}

function handleNoteTextFileNameHook(note) {
Expand Down