fix: don't stop roll if grid cannot scroll in given direction

qooxdoo · Apr 11, 2024 · d22c75a · d22c75a
1 parent dc07721
commit d22c75a
Showing 1 changed file with 7 additions and 1 deletion.
diff --git a/source/class/qxl/datagrid/DataGrid.js b/source/class/qxl/datagrid/DataGrid.js
@@ -358,23 +358,29 @@ qx.Class.define("qxl.datagrid.DataGrid", {
      * @returns
      */
     _onRoll(e) {
-      e.stop();
       const SCROLLING_SPEED = 0.08;
       // only wheel and touch
       if (e.getPointerType() == "mouse") {
+        e.stop();
         return;
       }
 
       if (this.__cancelRoll && e.getMomentum()) {
         e.stopMomentum();
         this.__cancelRoll = null;
+        e.stop();
         return;
       }
 
       let rowCount = this.getDataSourceSize().getRow();
       var newStartRowIndex = this.getStartRowIndex() + Math.floor(e.getDelta().y * SCROLLING_SPEED);
       let maxRows = this.getMaxRows();
       newStartRowIndex = qxl.datagrid.util.Math.clamp(0, Math.max(0, rowCount - maxRows), newStartRowIndex);
+
+      const isAtScrollLimit = newStartRowIndex == this.getStartRowIndex();
+      if (!isAtScrollLimit) {
+        e.stop();
+      }
       this.setStartRowIndex(newStartRowIndex);
     },