Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in MCWF that prevented saving before/after jumps #208

Merged
merged 2 commits into from
Mar 20, 2018

Conversation

david-pl
Copy link
Member

For reference: the bug is related to this issue SciML/DiffEqCallbacks.jl#30
Once that is resolved, we can clean up the source code accordingly.

@coveralls
Copy link

coveralls commented Mar 20, 2018

Coverage Status

Coverage remained the same at 100.0% when pulling ca0ba80 on mcwf-displayevents into b7fbf03 on master.

@codecov
Copy link

codecov bot commented Mar 20, 2018

Codecov Report

Merging #208 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #208   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          34     34           
  Lines        2441   2475   +34     
=====================================
+ Hits         2441   2475   +34
Impacted Files Coverage Δ
src/mcwf.jl 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b7fbf03...ca0ba80. Read the comment docs.

@david-pl david-pl merged commit efe570c into master Mar 20, 2018
@david-pl david-pl deleted the mcwf-displayevents branch April 11, 2018 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants