Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating action versions #33

Merged
merged 2 commits into from
Apr 12, 2024
Merged

Updating action versions #33

merged 2 commits into from
Apr 12, 2024

Conversation

UmairK5669
Copy link
Member

Description:
Updated the actions versions to use un-deprecated Node.js versions.

Related Issues:
Solves the following warning in actions summary page:
Screenshot 2024-04-12 at 11 53 38 AM

Checklist:
Please be sure to check all boxes honestly. This is to ensure a smooth development process, and to reduce the
likelihood of needing to make additional changes later on.

  • I understand that changes authored by individuals who have not signed a Contributor License Agreement (CLA),
    or whose authorship we cannot verify, may not be accepted.
  • These contribution address a triaged issue.
  • I have performed a self-review of my code and my changes generate no new warnings.
  • I have included unit tests for my code contributions, and all tests are passing.
  • The docstrings are complete, include doctests demonstrating usage, and are properly formatted.
    I have verified that any updates to the project documentation are complete and look okay.
  • I have confirmed all my code contributions are formatted in accordance with the project's Flake8, Black,
    and isort style configurations.
  • No unnecessary changes have been made to the Poetry lock file, but pyproject.toml and the Poetry lock file
    have been updated to reflect any dependency changes.
  • I acknowledge that upon the submission of this pull request, Qoherent will assume the copyright for this
    contribution.

@UmairK5669
Copy link
Member Author

Note: For the flake8 lint workflow the latest version is 1.1 which still uses Node.js 16, which is why it still shows deprecated.

@UmairK5669 UmairK5669 requested a review from mrl280 April 12, 2024 16:09
Copy link
Collaborator

@mrl280 mrl280 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@UmairK5669 UmairK5669 merged commit a2af5f9 into main Apr 12, 2024
2 of 3 checks passed
@UmairK5669 UmairK5669 deleted the workflow-version branch April 12, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants