-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Codecov Workflow #22
Conversation
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
…to codecov-workflow
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should these dependencies be moved to the tool.poetry.group.test.dependencies
?
Looks good overall, I think let's remove the dummy tests so they don't reach the main branch. |
Note: We will need to squash the commits at merge time. |
It looks like test_dummy.py is already in main, should we be removing it? |
Yeah, I think they should, they don't really serve a purpose and were only for testing this workflow. |
Description:
Added a Codecov workflow that will allow
pytest
to perform any tests and upload the coverage to codecov using thepytest-cov
dependency that has been added topyproject.toml
. This workflow will run on code that is pushed to themain
branch as well as PRs that intend to merge intomain
.Related Issues:
#12
Outstanding Sub-Issues:
This workflow simply uploads the test coverage to Codecov and doesn't check to see if it meets the threshold.
Tips for the Reviewer:
As there are no tests that Ria has presently, I would highly recommend adding dummy tests to test the workflow. After adding dummy tests run
poetry run pytest
to first ensure the tests are being ran, then push the code to this branch and the workflow will run automatically.Checklist:
Please be sure to check all boxes honestly. This is to ensure a smooth development process, and to reduce the
likelihood of needing to make additional changes later on.
or whose authorship we cannot verify, may not be accepted.
I have verified that any updates to the project documentation are complete and look okay.
configuration.
pyproject.toml
and the Poetry lock filehave been updated to reflect any dependency changes.
contribution.
A heartfelt thank you from everyone at Qoherent and the broader radio community for taking the time to contribute to
RIA Core. 🙏💖