Qhc 836 voltage unit input in volts for gain and amplitude

[jordivallsq]

Gain is now normalized [-1, 1] and waveform amplitude is described in Voltage (QRM/direct lines is [-0.5, 0.5] V and QCM/amplified lines is [-2.5, 2.5] V)

[linear]

QHC-836 Voltage unit input in volts for gain and amplitude

[pullpo-for-slack]

🔗Pullpo.io Slack channel

[pullpo-for-slack]

AI Analysis

Review:

The changes in test_qblox_compiler.py seem to be focused on enhancing the functionality related to voltage coefficients in the compile method calls. The added import statements for logging, is_q1asm_equal, and ForLoop indicate that the code is being extended to incorporate additional features and dependencies. It's important to ensure that the usage of the voltage_coefficient argument is consistent and well-documented throughout the codebase.

Detailed file changes

(dropdown):

In tests/qprogram/test_qblox_compiler.py:

• Added import statement for logging
• Added import statement for is_q1asm_equal from tests.test_utils
• Added import statement for ForLoop from qililab.qprogram.blocks
• Added voltage_coefficient argument in the compile method calls
• Added voltage_coefficient argument in the compile method calls
• Added voltage_coefficient argument in the compile method calls

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.29%. Comparing base (000eafe) to head (6342a95).

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #884   +/-   ##
=======================================
  Coverage   97.29%   97.29%           
=======================================
  Files         231      231           
  Lines        8229     8236    +7     
=======================================
+ Hits         8006     8013    +7     
  Misses        223      223           

Flag	Coverage Δ
unittests	97.29% <100.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.