Qhc 848 support iq modulation for r&s sgs100 a

docs/releases/changelog-dev.md

@@ -10,9 +10,12 @@
   Each chunk duration is restricted to the range (\[100, 500\]) ns, ensuring that chunks are neither too small (leading to excessive repetitions) nor too large (risking out-of-memory issues). If no duration within (\[100, 500\]) ns meets these remainder constraints, the compiler defaults to using the original waveform in its entirety.
   [#861](https://github.com/qilimanjaro-tech/qililab/pull/861)
 
--Raises an error when the inputed value for the QDAC is outside of the bounds provided by QM. Done in 3 ways, runcard, set_parameter RAMPING_ENABLED and set_parameter RAMPING_RATE.
+- Raises an error when the inputed value for the QDAC is outside of the bounds provided by QM. Done in 3 ways, runcard, set_parameter RAMPING_ENABLED and set_parameter RAMPING_RATE.
 [#865](https://github.com/qilimanjaro-tech/qililab/pull/865)
 
+- Code to enable the IQ mixer feature already part of qcode in qililab for the rohde and schwarz SGS100a
+[#872](https://github.com/qilimanjaro-tech/qililab/pull/872)
+
 
 ### Improvements
 

src/qililab/instruments/rohde_schwarz/sgs100a.py

@@ -48,6 +48,7 @@ class SGS100ASettings(Instrument.InstrumentSettings):
         power: float
         frequency: float
         rf_on: bool
+        hardware_modulation: bool
 
     settings: SGS100ASettings
     device: RohdeSchwarzSGS100A
@@ -78,6 +79,15 @@ def rf_on(self):
         """
         return self.settings.rf_on
 
+    @property
+    def hardware_modulation(self):
+        """SignalGenerator 'IQ state' property.
+
+        Returns:
+            bool: settings.hardware_modulation.
+        """
+        return self.settings.hardware_modulation
+
     def to_dict(self):
         """Return a dict representation of the SignalGenerator class."""
         return dict(super().to_dict().items())
@@ -106,6 +116,12 @@ def set_parameter(self, parameter: Parameter, value: ParameterValue, channel_id:
                 else:
                     self.turn_off()
             return
+        if parameter == Parameter.HARDWARE_MODULATION:
+            value = bool(value)
+            self.settings.hardware_modulation = value
+            if self.is_device_active():
+                self.device.IQ_state(value)
+            return
         raise ParameterNotFound(self, parameter)
 
     def get_parameter(self, parameter: Parameter, channel_id: ChannelID | None = None) -> ParameterValue:
@@ -115,13 +131,16 @@ def get_parameter(self, parameter: Parameter, channel_id: ChannelID | None = Non
             return self.settings.frequency
         if parameter == Parameter.RF_ON:
             return self.settings.rf_on
+        if parameter == Parameter.HARDWARE_MODULATION:
+            return self.settings.hardware_modulation
         raise ParameterNotFound(self, parameter)
 
     @check_device_initialized
     def initial_setup(self):
         """performs an initial setup"""
         self.device.power(self.power)
         self.device.frequency(self.frequency)
+        self.device.hardware_modulation(self.hardware_modulation)
         if self.rf_on:
             self.device.on()
         else:

tests/calibration/galadriel.yml

@@ -267,6 +267,7 @@ instruments:
     power: 16
     frequency: 8.0726e+09
     rf_on: true
+    hardware_modulation: true
   - name: mini_circuits
     alias: attenuator
     attenuation: 32

tests/data.py

@@ -453,6 +453,7 @@ class Galadriel:
         Parameter.POWER.value: 15,
         Parameter.LO_FREQUENCY.value: 7.24730e09,
         Parameter.RF_ON.value: True,
+        Parameter.HARDWARE_MODULATION.value: True,
     }
 
     rohde_schwarz_controller_1: dict[str, Any] = {
@@ -478,6 +479,7 @@ class Galadriel:
         Parameter.POWER.value: 15,
         Parameter.LO_FREQUENCY.value: 3.351e09,
         Parameter.RF_ON.value: True,
+        Parameter.HARDWARE_MODULATION.value: True,
     }
 
     attenuator_controller_0: dict[str, Any] = {
@@ -621,6 +623,7 @@ class SauronYokogawa:
         Parameter.POWER.value: 15,
         Parameter.LO_FREQUENCY.value: 7.24730e09,
         Parameter.RF_ON.value: True,
+        Parameter.HARDWARE_MODULATION.value: True,
     }
 
     yokogawa_gs200_current_controller = {
@@ -709,6 +712,7 @@ class SauronSpiRack:
         Parameter.POWER.value: 15,
         Parameter.LO_FREQUENCY.value: 7.24730e09,
         Parameter.RF_ON.value: True,
+        Parameter.HARDWARE_MODULATION.value: True,
     }
 
     spi_rack_controller_usb = {
@@ -779,6 +783,7 @@ class SauronQDevil:
         Parameter.POWER.value: 15,
         Parameter.LO_FREQUENCY.value: 7.24730e09,
         Parameter.RF_ON.value: True,
+        Parameter.HARDWARE_MODULATION.value: True,
     }
 
     qdevil_qdac2_controller_ip = {
@@ -1276,6 +1281,7 @@ class SauronQuantumMachines:
         Parameter.POWER.value: 15,
         Parameter.LO_FREQUENCY.value: 7.24730e09,
         Parameter.RF_ON.value: True,
+        Parameter.HARDWARE_MODULATION.value: True,
     }
 
     qmm_controller_wrong_module = {

tests/instrument_controllers/qblox/qblox_runcard.yaml

@@ -20,6 +20,7 @@ instruments:
     power: 15
     frequency: 7e9
     rf_on: True
+    hardware_modulation: True
 
 instrument_controllers:
   - name: qblox_cluster

tests/instruments/rohde_schwarz/test_rohde_schwarz_sgs100a.py

@@ -6,6 +6,7 @@
 from qililab.instruments import SGS100A, ParameterNotFound
 from qililab.typings.enums import Parameter
 
+
 @pytest.fixture(name="sdg100a")
 def fixture_sdg100a() -> SGS100A:
     """Fixture that returns an instance of a dummy QDAC-II."""
@@ -14,18 +15,36 @@ def fixture_sdg100a() -> SGS100A:
             "alias": "qdac",
             "power": 100,
             "frequency": 1e6,
-            "rf_on": True
+            "rf_on": True,
+            "hardware_modulation": True
         }
     )
     sdg100a.device = MagicMock()
     return sdg100a
 
+
+@pytest.fixture(name="sdg100a_iq")
+def fixture_sdg100a_iq() -> SGS100A:
+    """Fixture that returns an instance of a dummy QDAC-II."""
+    sdg100a_iq = SGS100A(
+        {
+            "alias": "qdac",
+            "power": 100,
+            "frequency": 1e6,
+            "rf_on": True,
+            "hardware_modulation": True
+        }
+    )
+    sdg100a_iq.device = MagicMock()
+    return sdg100a_iq
+
+
 class TestSGS100A:
     """Unit tests checking the SGS100A attributes and methods"""
 
     @pytest.mark.parametrize(
         "parameter, value",
-        [(Parameter.POWER, 0.01), (Parameter.LO_FREQUENCY, 6.0e09), (Parameter.RF_ON, True), (Parameter.RF_ON, False)],
+        [(Parameter.POWER, 0.01), (Parameter.LO_FREQUENCY, 6.0e09), (Parameter.RF_ON, True), (Parameter.RF_ON, False), (Parameter.HARDWARE_MODULATION, True), (Parameter.HARDWARE_MODULATION, False)],
     )
     def test_set_parameter_method(
         self, sdg100a: SGS100A, parameter: Parameter, value: float,
@@ -38,6 +57,8 @@ def test_set_parameter_method(
             assert sdg100a.settings.frequency == value
         if parameter == Parameter.RF_ON:
             assert sdg100a.settings.rf_on == value
+        if parameter == Parameter.HARDWARE_MODULATION:
+            assert sdg100a.settings.hardware_modulation == value
 
     def test_set_parameter_method_raises_error(self, sdg100a: SGS100A):
         """Test setup method"""
@@ -46,7 +67,7 @@ def test_set_parameter_method_raises_error(self, sdg100a: SGS100A):
 
     @pytest.mark.parametrize(
         "parameter, expected_value",
-        [(Parameter.POWER, 100), (Parameter.LO_FREQUENCY, 1e6), (Parameter.RF_ON, True)],
+        [(Parameter.POWER, 100), (Parameter.LO_FREQUENCY, 1e6), (Parameter.RF_ON, True), (Parameter.HARDWARE_MODULATION, True)],
     )
     def test_get_parameter_method(
         self, sdg100a: SGS100A, parameter: Parameter, expected_value: float,