[QHC-865] Follow up on Drag Bunching #868
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AI AnalysisReview:The removal of the TODO comment suggests that the task related to adding bunching drag gates for different phi's has been completed or deemed unnecessary. Changing the parameter
|
3 tasks
Co-authored-by: Vyron Vasileiadis <[email protected]>
GuillermoAbadLopez
added a commit
that referenced
this pull request
Jan 22, 2025
### TODOs in this PR: - [x] Make the deletion of gates with no amplitude (fill `delete_gates_with_no_amplitude(...)`) - [x] Make bunching of consecutive Drag Gates if phis equal (fill `bunch_drag_gates(... only_same_phi=True)`) - [x] Make tests to cover this, and manually check it works! --- ### And in the [next PR](#868), we will follow up on Drag Bunching, for different phis. --------- Co-authored-by: Vyron Vasileiadis <[email protected]>
Base automatically changed from
adding_optimize_transpiled_gates
to
solving-transpilation
January 22, 2025 18:20
16 tasks
GuillermoAbadLopez
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODOs in this PR: