-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ogr] Fix mapinfo (multi)polygon type layers #60410
[ogr] Fix mapinfo (multi)polygon type layers #60410
Conversation
🪟 Windows buildsDownload Windows builds of this PR for testing. 🪟 Windows Qt6 buildsDownload Windows Qt6 builds of this PR for testing. |
@elpaso I dug DEEP into the archives, and the behavior is coming from c8ff386 Which is a fix for https://web.archive.org/web/20240715001715/https://issues.qgis.org/issues/8001. note that there's NO tests for that issue/fix, so we should add those before continuing. That said, I think a cleaner fix would be to remove the single type conversion in the iteration loop entirely, and then implement the desired logic afterwards -- ie just before https://github.com/qgis/QGIS/blob/master/src/core/providers/ogr/qgsogrproviderutils.cpp#L2758 |
By not flattenting the geometry, for mapinfo only. Fixes qgis#60396
fd51e7f
to
3743612
Compare
I refactored the whole types collapsing logic, can you please have a look? |
By not flattening the geometry, it applies to all mixed geometry OGR layers
Fixes #60396