[Backport release-3_40] 3D views: use the correct resolution on high DPI displays! #60308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nowadays Qt gives us size in device independent pixels, and we were using those values for the textures as well - but that means on high DPI screens where device pixel ratio is 2, we were rendering in low resolution and then upscaling the textures. This should fix that, and intermediate textures use the correct size - the rendered output is much crispier, yay!
nyalldawson
approved these changes
Jan 28, 2025
|
Let's wait for a cycle with this? It's desirable but not critical |
🪟 Windows buildsDownload Windows builds of this PR for testing. 🪟 Windows Qt6 buildsDownload Windows Qt6 builds of this PR for testing. |
|
😏 super fast backport here ignoring my comment above |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #60247
Authored by: @wonder-sk