avoid non-standard b3dm data format problems #60258
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
After the modification is completed, it runs normally
|
alexbruy
requested changes
Jan 28, 2025
| @@ -185,6 +185,10 @@ void QgsTextDocumentMetrics::finalizeBlock( QgsTextDocumentMetrics &res, const Q | |||
| else | |||
| { | |||
| // html vertical margins between blocks collapse and take the size of the highest margin: | |||
| if (documentMetrics.verticalMarginsBetweenBlocks.isEmpty()) { | |||
| qWarning() << "verticalMarginsBetweenBlocks is empty!"; | |||
There was a problem hiding this comment.
Please, replace this with the QgsDebugMsgLevel()
nyalldawson
requested changes
Feb 2, 2025
There was a problem hiding this comment.
also see #60256 (comment) -- this should not be merged before a reproducible test case is available.
|
The correct fix is probably #60423 -- can you test and confirm? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
print 3d layout bug:
Fixes #60256