Use undostack in paintbrush tool & refactor deps

qgis · Jan 31, 2025 · 6aed037 · 6aed037
1 parent f8a7ba9
commit 6aed037
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 11 deletions.
diff --git a/src/app/3d/qgs3dmapcanvaswidget.cpp b/src/app/3d/qgs3dmapcanvaswidget.cpp
@@ -16,14 +16,12 @@
 #include "qgs3dmapcanvaswidget.h"
 #include "moc_qgs3dmapcanvaswidget.cpp"
 
-#include <QBoxLayout>
-#include <QDialog>
-#include <QDialogButtonBox>
 #include <QProgressBar>
 #include <QToolBar>
-#include <QUrl>
 #include <QAction>
 #include <QShortcut>
+#include <QWidget>
+#include <QActionGroup>
 
 #include "qgisapp.h"
 #include "qgs3dmapcanvas.h"
@@ -51,7 +49,6 @@
 #include "qgs3dnavigationwidget.h"
 #include "qgs3ddebugwidget.h"
 #include "qgs3dutils.h"
-#include "qgswindow3dengine.h"
 
 #include "qgsmap3dexportwidget.h"
 #include "qgs3dmapexportsettings.h"
@@ -61,9 +58,6 @@
 #include "qgsrubberband.h"
 #include "qgspointcloudlayer.h"
 
-#include <QWidget>
-#include <QActionGroup>
-
 Qgs3DMapCanvasWidget::Qgs3DMapCanvasWidget( const QString &name, bool isDocked )
   : QWidget( nullptr )
   , mCanvasName( name )

diff --git a/src/app/3d/qgs3dmaptoolpaintbrush.cpp b/src/app/3d/qgs3dmaptoolpaintbrush.cpp
@@ -26,12 +26,11 @@
 #include "qgsguiutils.h"
 #include "qgsmultipoint.h"
 #include "qgspointcloudlayer.h"
+#include "qgs3dmaptoolpointcloudchangeattribute.h"
+#include "qgisapp.h"
 
 #include <QCursor>
 #include <QMouseEvent>
-#include <qgisapp.h>
-#include <qgs3dmaptoolpointcloudchangeattribute.h>
-
 
 class QgsPointCloudAttribute;
 Qgs3DMapToolPaintBrush::Qgs3DMapToolPaintBrush( Qgs3DMapCanvas *canvas )
@@ -56,10 +55,12 @@ void Qgs3DMapToolPaintBrush::processSelection() const
   int offset;
   const QgsPointCloudAttribute *attribute = pcLayer->attributes().find( mAttributeName, offset );
 
+  pcLayer->undoStack()->beginMacro( tr( "Change attribute values" ) );
   for ( auto it = sel.begin(); it != sel.end(); ++it )
   {
     pcLayer->changeAttributeValue( it.key(), it.value(), *attribute, mNewValue );
   }
+  pcLayer->undoStack()->endMacro();
 }
 
 SelectedPoints Qgs3DMapToolPaintBrush::searchPoints( QgsPointCloudLayer *layer, const QgsGeometry &searchPolygon ) const