Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated dependencies #4

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

Nazgull09
Copy link

@Nazgull09 Nazgull09 commented Dec 19, 2019

small fix for cabal file about updating imports.

Copy link

@endgame endgame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't remove the upper bounds; they're an important part of keeping build plans solvable, especially for older software (I recently had to make 25 revisions of http-conduit because they don't do upper bounds).

Once the bounds are right on this, I will make a metadata revision; this won't need a new release.

build-depends: base >=4.9 && <=4.12
build-depends: base
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't remove the upper bounds like this; you can use this wiki page to get the correct upper bound.

, reflex >= 0.5 && <0.6
, reflex-dom-core >= 0.4 && <0.5
, reflex >= 0.4 && < 0.7
, reflex-dom-core
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a correct upper bound here.

@exarkun exarkun mentioned this pull request Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants