Feature: sink level and common update #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* update: clang-format rules Signed-off-by: Dmitriy Khaustov aka xDimon <[email protected]> * update: format the following updated rules Signed-off-by: Dmitriy Khaustov aka xDimon <[email protected]> * feature: max level for sink Signed-off-by: Dmitriy Khaustov aka xDimon <[email protected]> * update: explaining comment of config options Signed-off-by: Dmitriy Khaustov aka xDimon <[email protected]> * fix: some crashes at log configuration Signed-off-by: Dmitriy Khaustov aka xDimon <[email protected]> * update: clang-tidy rules Signed-off-by: Dmitriy Khaustov aka xDimon <[email protected]> * update: CI workflows Signed-off-by: Dmitriy Khaustov aka xDimon <[email protected]> * fix: clang-tidy issues Signed-off-by: Dmitriy Khaustov aka xDimon <[email protected]> * fix linker error (#33) Signed-off-by: turuslan <[email protected]> (cherry picked from commit 444f3da) --------- Signed-off-by: Dmitriy Khaustov aka xDimon <[email protected]> (cherry picked from commit 042712e)
igor-egorov
previously approved these changes
Oct 14, 2024
turuslan
previously approved these changes
Oct 14, 2024
| @@ -21,13 +21,13 @@ | |||
| */ | |||
|
|
|||
| #define _SL_LOG_IF_LEVEL(LOG, LVL, FMT, ...) \ | |||
| do { \ | |||
| ({ \ | |||
There was a problem hiding this comment.
Do we allow/use https://gcc.gnu.org/onlinedocs/gcc/Statement-Exprs.html ?
If we use it, then we may use BOOST_OUTCOME_TRYX
// OUTCOME_TRY but it's expression
auto x = BOOST_OUTCOME_TRYX(foo()) + BOOST_OUTCOME_TRYX(bar());
#define BOOST_OUTCOME_TRYX(expr)
({
auto tmp = expr;
// return inside statement expression
if (tmp.has_error()) return error;
tmp.value();
})
There was a problem hiding this comment.
Why not? This is topic for discuss
| if (level_string == "debug" || level_string == "deb") { | ||
| if constexpr (debug_level_disable) { | ||
| errors_ << "W: Level 'debug' in " << target << " won't work: " | ||
| << "it has disabled with compile option" |
There was a problem hiding this comment.
Suggested change
| << "it has disabled with compile option" | |
| << "it was disabled with compile option" |
xDimon
force-pushed
the
feature/sink_level_and_common_update
branch
4 times, most recently
from
c2587e9 to
7632dae
Compare
Signed-off-by: Dmitriy Khaustov aka xDimon <[email protected]>
xDimon
force-pushed
the
feature/sink_level_and_common_update
branch
from
7632dae to
a30f060
Compare
Harrm
approved these changes
Oct 14, 2024
igor-egorov
approved these changes
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#13@xDimon/soralog