-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add announce_port support #21692
base: master
Are you sure you want to change the base?
Add announce_port support #21692
Conversation
5ae627b
to
6caafc8
Compare
On a side-note, the |
6caafc8
to
ee04f2e
Compare
This PR is stale because it has been 60 days with no activity. This PR will be automatically closed within 7 days if there is no further activity. |
This PR was closed because it has been stalled for some time with no activity. |
@0xThiebaut: What is the situation of your PR? |
@Neustradamus this PR was closed due to inactivity as completing the PR required the upstream arvidn/libtorrent#7771 change to reach a release. libtorrent:v2.0.11 was released 3 days ago so I will re-open the PR this weekend. |
@0xThiebaut FYI - libtorrent 2.0.11 isn't available in our CI yet, however #22217 is open/approved & should be merged within the next day. |
Thanks for the heads-up @xavier2k6 , any chance you have the permissions to reopen this PR? It was closed as stale and I'd prefer re-opening it to maintain the history instead of filing a new one. |
Re-opened |
ee04f2e
to
00c4d70
Compare
Pending #22217 |
Merged now. |
@0xThiebaut It mat be worthwhile to re-base. |
00c4d70
to
b76b3a5
Compare
Rebased. |
b76b3a5
to
a29cb29
Compare
a29cb29
to
303e6a2
Compare
The
announce_port
setting permits to overwrite the port passed along to trackers as the&port=
parameter. If left as the default, the listening port is used. This setting is only meant for very special cases where a seed's listening port differs from the effectively exposed port (e.g., through external NAT-PMP). See arvidn/libtorrent#7771 for an example use-case.This PR adds the relevant setting alongside the existing
![image](https://private-user-images.githubusercontent.com/46688461/380481092-56303902-204e-4362-b5c8-9759a6c42516.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzg5MjY3NTAsIm5iZiI6MTczODkyNjQ1MCwicGF0aCI6Ii80NjY4ODQ2MS8zODA0ODEwOTItNTYzMDM5MDItMjA0ZS00MzYyLWI1YzgtOTc1OWE2YzQyNTE2LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMDclMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjA3VDExMDczMFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWU3ZjQ1YWM1YzMzNmU4MGMzNDFhYmVmNDYyNWU3MGY2ZjgyZGIzMzc0MjlkZjFmOGMzMzYwYmE3YmNkMzhkYTEmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.l6ab4W_jLRlsWNXyHnRYYYeGQBReCiK_R7v_jtbAivU)
announce_ip
setting.The setting subsequently modifies the announced port (
&port=1234
):