-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update aoti tutorial #3224
base: 2.6-RC-TEST
Are you sure you want to change the base?
Update aoti tutorial #3224
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/tutorials/3224
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ✅ No FailuresAs of commit 805a1b2 with merge base d8a9749 (): This comment was automatically generated by Dr. CI and updates every 15 minutes. |
e5b36b6
to
336579d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple of minor nits.
336579d
to
14e064a
Compare
# | ||
# - ``torch._inductor.aot_compile`` generates a shared library. This is useful for model | ||
# versioning for deployments and tracking model performance over time. | ||
# - With :func:`torch.compile` being a JIT compiler, there is a warmup |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is particularly true if a user wants to apply max-autotune, so it's worth to mention here.
# Once this requirement is met, the primary use case for using AOTInductor Python Runtime is for | ||
# model deployment using Python. | ||
# There are mainly two reasons why you would use AOTInductor Python Runtime: | ||
# There are mainly two reasons why one would use AOTInductor with a Python Runtime: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Duplicate of the last section?
14e064a
to
805a1b2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I'll send a follow-up PR for the expected behavior with docker image
LGTM! Let's wait until 2.6 is available in main and merge into main not into 2.6-RC-TEST - I will follow up on that. |
Fixes #ISSUE_NUMBER
Description
Updated AOTI tutorial with new packaging APIs
Checklist