Apply Repo-Review suggestion #1039
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,6 +1,6 @@ | |||
| # pyproject.toml | |||
| [build-system] | |||
| requires = ["setuptools>=45", "wheel", "setuptools_scm[toml]>=6.0"] | |||
| requires = ["setuptools>=45", "setuptools_scm[toml]>=6.0"] | |||
There was a problem hiding this comment.
I seem to recall "setuptools>=61" is requited for PEP517 compliance. Is that why you explicitly require "wheel"?
PP003: Does not list wheel as a build-dep Do not include "wheel" in your build-system.requires, setuptools does this via PEP 517 already. Setuptools will also only require this for actual wheel builds, and might have version limits.
DimitriPapadopoulos
force-pushed
the
repo-review
branch
from
d65fb70 to
39edd10
Compare
|
Once again, there is an effort to apply a rule from a linter not in use and which has many other items that could be addressed when the linter is designed for a different set of projects altogether (scientific Python). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apply a Repo-Review suggestion.
Do not include
"wheel"in yourbuild-system.requires, setuptools does this via PEP 517 already. Setuptools will also only require this for actual wheel builds, and might have version limits.