Fix crash formatting error message #4809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ngoldbaum
force-pushed
the
fix-error-crash
branch
from
d3f193b to
e5f740d
Compare
Avasam
reviewed
Jan 18, 2025
|
Thank you very much @ngoldbaum. How about we just drop the ABI note? This would get rid of the branching and make the code more robust to errors. I don't think that the note adds much more information than what the rest of the message is already providing? |
abravalheri
reviewed
Jan 20, 2025
Co-authored-by: Avasam <[email protected]>
Co-authored-by: Anderson Bravalheri <[email protected]>
Co-authored-by: Anderson Bravalheri <[email protected]>
abravalheri
force-pushed
the
fix-error-crash
branch
from
7c76a8a to
d92a595
Compare
|
Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Avoids an
AttributeErroron non-posix systems, wheresys.abiflagsisn't set.Closes #4807
This code was originally authored by @abravalheri in #4424. I think the non-POSIX limitation was just missed there.
That PR didn't add tests for this error so I thought it was fair game to fix it without a test as well 🙃.
Pull Request Checklist
newsfragments/.(See documentation for details)