Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clarified docs for env-vars and config files #13050

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

zerothi
Copy link

@zerothi zerothi commented Oct 27, 2024

More links between sections are added.
It should bring all documentation together
in a more coherent manner.

The Environemnt variables section has been
cleaned.
Now there are not 3 random examples which
might have confused users to only suspect that those 3 examples where the only available ones.
Now this section clarifies how any CLI-option
is specified through an env var, and clarifies
that the shell example, is an example.

@zerothi
Copy link
Author

zerothi commented Oct 27, 2024

This was born out of the discussion in #13043, hence the branch reference.

More links between sections are added.
It should bring all documentation together
in a more coherent manner.

The Environemnt variables section has been
cleaned.
Now there are not 3 *random* examples which
might have confused users to only suspect that those
3 examples where the only available ones.
Now this section clarifies how *any* CLI-option
is specified through an env var, and clarifies
that the shell example, *is* an example.

Signed-off-by: Nick Papior <[email protected]>
Signed-off-by: Nick Papior <[email protected]>
@zerothi zerothi force-pushed the 13043-docs-env-vars branch from dc77343 to 627a1ae Compare October 27, 2024 19:24
@ichard26 ichard26 self-requested a review December 12, 2024 21:33
@ichard26 ichard26 added the type: docs Documentation related label Dec 12, 2024
Copy link
Member

@ichard26 ichard26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for long delay. Improvements to pip's documentation are appreciated. I like where this is going, but I do think this needs some tweaking.

docs/html/topics/configuration.md Outdated Show resolved Hide resolved
docs/html/topics/configuration.md Outdated Show resolved Hide resolved
docs/html/topics/configuration.md Show resolved Hide resolved
docs/html/topics/configuration.md Outdated Show resolved Hide resolved
docs/html/topics/configuration.md Outdated Show resolved Hide resolved
docs/html/topics/configuration.md Outdated Show resolved Hide resolved
docs/html/topics/configuration.md Outdated Show resolved Hide resolved
docs/html/topics/configuration.md Outdated Show resolved Hide resolved
@ichard26 ichard26 added the skip news Does not need a NEWS file entry (eg: trivial changes) label Dec 16, 2024
Copy link
Member

@ichard26 ichard26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your patience!

@zerothi
Copy link
Author

zerothi commented Dec 17, 2024

Great! Looks complete to me!

@ichard26 ichard26 added this to the 25.0 milestone Dec 24, 2024
```shell
PIP_VERBOSE=3 PIP_CACHE_DIR=/home/user/tmp pip ...
PIP_FIND_LINKS="http://mirror1.example.com http://mirror2.example.com" pip ...
PIP_NO_DEPS=yes pip ...
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this part work as is on Windows, or should this part use tabs?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Windows doesn't support the ENV_VAR=value command syntax at all. The examples would need to use

set PIP_VERBOSE=3
set PIP_CACHE_DIR=C:\Temp
pip ...

(CMD syntax), or

$env:PIP_VERBOSE=3
$env:PIP_CACHE_DIR="C:\Temp"
pip ...

(Powershell syntax). I'm not sure whether our Windows examples use CMD or Powershell - the ones I could find work the same in both shells. There's also the complication that if you want multiple examples, you need to unset the variables from the previous example on Windows - again because the ENV=value cmd syntax doesn't exist.

To be honest, giving explicit examples of shell syntax might be more confusing than helpful for beginners, and advanced users can probably work out the shell syntax based on a description.

One possible compromise would be to use the env command - env PIP_VERBOSE=3 PIP_CACHE_DIR=/home/user/tmp pip .... The env command doesn't exist by default on Windows, but it's possible to find ports of it. It's not ideal, but it's the only real way of getting a proper Windows equivalent of the Unix examples given (and it has the advantage that it works fine on Unix as well 🙂)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree on @pfmoore views, there are many places were there is no differentiation between unix/powershell/command.. So I think it can go directly in.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hang on, I was not saying this could be left as it is. Quite the opposite, I was saying that the docs need to be platform-neutral, but that's near-impossible to do in this case, so we should stick with describing the behaviour in the text, without trying to give examples.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:provided skip news Does not need a NEWS file entry (eg: trivial changes) type: docs Documentation related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants