-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add loongarch64 platform support #522
base: main
Are you sure you want to change the base?
Conversation
@wxpppp GLIBC_2.34 GLIBC_2.36 GLIBC_2.38 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #522 +/- ##
=======================================
Coverage 92.01% 92.01%
=======================================
Files 20 20
Lines 1315 1315
Branches 247 247
=======================================
Hits 1210 1210
Misses 65 65
Partials 40 40 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Weijie Wang <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems almost correct but I can't really check this.
"loongarch64": { | ||
"CXXABI": ["1.3", "1.3.1", "1.3.2", "1.3.3", "1.3.4", "1.3.5", "1.3.6", "1.3.7", "1.3.8", "1.3.9", "1.3.10", "1.3.11", "1.3.12", "1.3.13", "TM_1"], | ||
"GCC": ["3.0", "3.3", "3.3.1", "3.4", "3.4.2", "3.4.4", "4.0.0", "4.2.0", "4.3.0", "4.4.0", "4.5.0", "4.7.0", "7.0.0"], | ||
"GLIBC": ["2.36", "ABI_DT_RELR"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems wrong.
"GLIBC": ["2.36", "ABI_DT_RELR"], | |
"GLIBC": ["2.36", "2.37", "ABI_DT_RELR"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello, thank you for reviewing the code. I have tested it on a machine with the LoongArch platform, and indeed, the symbol GLIBC_2.37 is not present in the libc.so of the corresponding version.
You can run a LoongArch container environment on an x86 machine as follows:
|
When I used the auditwheel tool to repair a wheel package on the LoongArch64 Alpine platform, I encountered an error. So, I added some LoongArch64 platform-related code to support musllinux and manylinux.
PS: Alpine v3.21 has support loongarch64 platform.(https://wiki.alpinelinux.org/wiki/Loongarch64)