Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add loongarch64 platform support #522

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

add loongarch64 platform support #522

wants to merge 1 commit into from

Conversation

wxpppp
Copy link

@wxpppp wxpppp commented Dec 20, 2024

When I used the auditwheel tool to repair a wheel package on the LoongArch64 Alpine platform, I encountered an error. So, I added some LoongArch64 platform-related code to support musllinux and manylinux.

PS: Alpine v3.21 has support loongarch64 platform.(https://wiki.alpinelinux.org/wiki/Loongarch64)

@wojiushixiaobai
Copy link

wojiushixiaobai commented Dec 31, 2024

@wxpppp
Hello, can the code be adapted for manylinux_2_34?
It is recommended to support it from manylinux_2_31 like the riscv64 architecture.

GLIBC_2.34

GLIBC_2.36

GLIBC_2.38

Copy link

codecov bot commented Jan 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.01%. Comparing base (7d50cf2) to head (219bd45).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #522   +/-   ##
=======================================
  Coverage   92.01%   92.01%           
=======================================
  Files          20       20           
  Lines        1315     1315           
  Branches      247      247           
=======================================
  Hits         1210     1210           
  Misses         65       65           
  Partials       40       40           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@mayeut mayeut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems almost correct but I can't really check this.

"loongarch64": {
"CXXABI": ["1.3", "1.3.1", "1.3.2", "1.3.3", "1.3.4", "1.3.5", "1.3.6", "1.3.7", "1.3.8", "1.3.9", "1.3.10", "1.3.11", "1.3.12", "1.3.13", "TM_1"],
"GCC": ["3.0", "3.3", "3.3.1", "3.4", "3.4.2", "3.4.4", "4.0.0", "4.2.0", "4.3.0", "4.4.0", "4.5.0", "4.7.0", "7.0.0"],
"GLIBC": ["2.36", "ABI_DT_RELR"],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems wrong.

Suggested change
"GLIBC": ["2.36", "ABI_DT_RELR"],
"GLIBC": ["2.36", "2.37", "ABI_DT_RELR"],

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, thank you for reviewing the code. I have tested it on a machine with the LoongArch platform, and indeed, the symbol GLIBC_2.37 is not present in the libc.so of the corresponding version.

@wxpppp
Copy link
Author

wxpppp commented Jan 21, 2025

You can run a LoongArch container environment on an x86 machine as follows:

docker run --rm --privileged ghcr.io/loong64/qemu-user-static --reset -p yes
# Debian
docker run --rm --platform linux/loong64 -it ghcr.io/loong64/debian:trixie-slim bash

@wxpppp wxpppp requested a review from mayeut January 21, 2025 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants