Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build numpy from src in integration test #65

Merged
merged 19 commits into from
Dec 2, 2024

Conversation

ryanking13
Copy link
Member

Build numpy using pyodide build command in the integration test.

Copy link
Member

@agriyakhetarpal agriyakhetarpal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @ryanking13! NumPy builds with Meson, so this is nice to see. Could we also add one more Scientific Python project, say, one that relies on a different build backend such as scikit-build-core? We are not constrained by the number of CI jobs, and there would be scope for parallelising them.

integration_tests/src/numpy.sh Outdated Show resolved Hide resolved
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can make this a Python file instead of a shell script (it would help in the case we establish Windows support someday, now that Emscripten is generally available through Windows package managers)?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are never establishing windows support. People on Windows can use windows subsystem linux.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, no worries! There is a chance things might work for anyone trying it out with minimal changes (except for the shell scripts, I guess), so if someone wants, they can do those changes themselves.

@ryanking13
Copy link
Member Author

ryanking13 commented Dec 2, 2024

I updated the target to Numpy v2.0.2. I'll go ahead and merge this PR. Lets add more test cases in the follow-up PRs.

@ryanking13 ryanking13 merged commit cee649f into pyodide:main Dec 2, 2024
5 checks passed
@ryanking13 ryanking13 deleted the more-integraion-tests branch December 2, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants