Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StateSpace Module Hurricane Case Study WIP #763

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

Dekermanjian
Copy link
Contributor

@Dekermanjian Dekermanjian commented Dec 30, 2024

Case Study to showcase the use of the State Space Module in pymc-experimental

This relates to #715

In this case study I have done the following:

  • Briefly explain how SSMs work under the hood
  • Walk through the simplest form of SSM for tracking a 2-D object

I still wish to add the following:

  • Expand on the simplest SSM by adding covariates/exogenous variables
  • Implement a VARMAX model in the state space representation
  • Add non-linear covariates/exogenous variables like HSGPs

@jessegrabowski Once I have completed this, would you be willing to be a reviewer for this case study?


📚 Documentation preview 📚: https://pymc-examples--763.org.readthedocs.build/en/763/

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link

review-notebook-app bot commented Jan 5, 2025

View / edit / reply to this conversation on ReviewNB

fonnesbeck commented on 2025-01-05T01:33:47Z
----------------------------------------------------------------

Not sure if its my setup, but there are some stray $ characters in the intro.


Dekermanjian commented on 2025-01-05T11:37:14Z
----------------------------------------------------------------

Hi @fonnesneck! Thank you for taking the time to review this notebook. On ReviewNB it seems that the double $ that should generate an equation on its own line doesn't render, but it does on the PyMC examples page. That is why there are stray $ characters.

Copy link

review-notebook-app bot commented Jan 5, 2025

View / edit / reply to this conversation on ReviewNB

fonnesbeck commented on 2025-01-05T01:33:48Z
----------------------------------------------------------------

We don't currently use plotly in any of the other examples, so need to update the requirements.


Dekermanjian commented on 2025-01-05T11:41:24Z
----------------------------------------------------------------

Yes, you are correct. I will move the comment on line 6 to the very top of this cell. I have Plotly included in the extra_installs in the myst.md file. Again this does not render in ReviewNB but it does on the PyMC examples website. You can see it if you visit the documentation preview https://pymcio--763.org.readthedocs.build/projects/examples/en/763/case_studies/ssm_hurricane_tracking.html

Copy link

review-notebook-app bot commented Jan 5, 2025

View / edit / reply to this conversation on ReviewNB

fonnesbeck commented on 2025-01-05T01:33:49Z
----------------------------------------------------------------

spelling: "originate"

Also, maybe worth adding a sentence describing what defines an origination point.


Dekermanjian commented on 2025-01-05T11:43:24Z
----------------------------------------------------------------

Thank you for catching that! Yes, I agree with you. I will add some more context on what constitutes an origination point.

Copy link
Contributor Author

Hi @fonnesneck! Thank you for taking the time to review this notebook. On ReviewNB it seems that the double $ that should generate an equation on its own line doesn't render, but it does on the PyMC examples page. That is why there are stray $ characters.


View entire conversation on ReviewNB

Copy link
Contributor Author

Yes, you are correct. I will move the comment on line 6 to the very top of this cell. I have Plotly included in the extra_installs in the myst.md file. Again this does not render in ReviewNB but it does on the PyMC examples website. You can see it if you visit the documentation preview https://pymcio--763.org.readthedocs.build/projects/examples/en/763/case_studies/ssm_hurricane_tracking.html


View entire conversation on ReviewNB

Copy link
Contributor Author

Thank you for catching that! Yes, I agree with you. I will add some more context on what constitutes an origination point.


View entire conversation on ReviewNB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant