Port event.c to SDL3 #3217
Merged
Port event.c to SDL3 #3217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ankith26
force-pushed
the
ankith26-more-sdl3-4
branch
from
435b8a3 to
4622f42
Compare
Starbuck5
approved these changes
Nov 18, 2024
There was a problem hiding this comment.
Thanks Ankith!
I'm approving this because I think it is safe and ready to merge, but I also have some obvious suggestions you've probably thought about yourself.
It seems like the largest difference by lines is event->key.keysym vs event->key. Maybe there could be a compatibility macro like PG_EV_KEYDATA(event) or something, I believe this would shrink the diff in event.c. I also think the cdevice -> gdevice, ctouchpad -> gtouchpad stuff would be a good opportunity for a compat macro.
zoldalma999
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
event.cis now compiling on SDL3.This PR takes our usual strategy of not changing any SDL2 codepaths, and I have been super conservative with the changes.
The thing that needs discussion here is: how are we going to handle the gesture changes? For now I have just ifdef'd out the gesture parts, but maybe we should consider vendoring in SDL_gesture? Thoughts on this, chat?