Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SDL3: compile rect, bufferproxy, math, newbuffer, geometry #3145

Merged
merged 1 commit into from
Oct 6, 2024
Merged

SDL3: compile rect, bufferproxy, math, newbuffer, geometry #3145

merged 1 commit into from
Oct 6, 2024

Conversation

ankith26
Copy link
Member

@ankith26 ankith26 commented Oct 6, 2024 •
edited
Loading

Tackle the most low-hanging of the low-hanging fruits: rect, bufferproxy, math, newbuffer, geometry

@ankith26 ankith26 requested a review from a team as a code owner October 6, 2024 06:43
@Starbuck5
Copy link
Member

Things to discuss: Should we embrace SDL_ENABLE_OLD_NAMES and therefore not worry about the renaming in many places?

Yes!

@Starbuck5 Starbuck5 added the sdl3 label Oct 6, 2024
@ankith26 ankith26 marked this pull request as draft October 6, 2024 06:49
@ankith26 ankith26 force-pushed the ankith26-sdl3-compat branch from 07c2b73 to 0371abd Compare October 6, 2024 07:55
@ankith26 ankith26 changed the title Fix SDL3 compat issues in _pygame.h SDL3: compile rect, bufferproxy, math, newbuffer, geometry Oct 6, 2024
@ankith26 ankith26 marked this pull request as ready for review October 6, 2024 07:56
Starbuck5
Starbuck5 approved these changes Oct 6, 2024
View reviewed changes
Copy link
Member

@Starbuck5 Starbuck5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

bilhox
bilhox approved these changes Oct 6, 2024
View reviewed changes
Copy link
Contributor

@bilhox bilhox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@bilhox bilhox merged commit e2704e6 into main Oct 6, 2024
28 checks passed
@ankith26 ankith26 added this to the 2.5.2 milestone Oct 6, 2024
@ankith26 ankith26 deleted the ankith26-sdl3-compat branch October 6, 2024 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bilhox bilhox bilhox approved these changes

@Starbuck5 Starbuck5 Starbuck5 approved these changes

Assignees
No one assigned
Labels
sdl3
Projects
None yet
Milestone
2.5.2
Development

Successfully merging this pull request may close these issues.
3 participants
@ankith26 @Starbuck5 @bilhox