Use future annotations #265

MikeMitusov · 2024-01-20T14:34:46Z

I've added: from __future__ import annotations to all important files

johnbywater · 2024-01-20T19:37:45Z

What's wrong @MikeMitusov? Just let me resolve the trouble with singledispatch and future annotations?

…tions Fix future annotations (from #265) plus some changes to singledispatchmethod.

johnbywater · 2024-01-20T23:42:16Z

I merged all these changes in #266. Thank you very much for addressing this important aspect of the code. I spent a couple of hours figuring out what was broken with the singledispatchmethod code and fixed that (it was trying to resolve annotations too early and also resolving annotations required classmethod to be set with a __wrapped__ attribute so that the typing module can get the globals. But it all seems to work now. I appreciate your contribution, and hope you don't mind that I folded these things into this PR (you had closed your original one and removed the branch so I didn't know what else to do).

MikeMitusov changed the title ~~[fix-future] Use __future__ annotations~~ Use __future__ annotations Jan 20, 2024

MikeMitusov added 29 commits January 20, 2024 14:53

from __future__ import annotations

d8cc9c2

Update domainmodel.py

867dd4c

from __future__ import annotations

4a9146c

from __future__ import annotations

bf7a0a9

Update domainmodel.py

b912b70

Update test_application.py

6bb162d

from __future__ import annotations

b935045

from __future__ import annotations

90fd584

Update test_application.py

2d31c6f

Update application.py

1eea43a

Update domainmodel.py

3aad905

from __future__ import annotations

177fba5

from __future__ import annotations

b5b4ddc

Update domainmodel.py

af2421b

Update test_application.py

ced21fb

from __future__ import annotations

1018bd6

from __future__ import annotations

0485bfc

from __future__ import annotations

0bd22b9

Update application.py

1bacf7a

Update persistence.py

d23007a

Update test_application.py

f46addf

Update test_compression_and_encryption.py

42fc206

Update test_snapshotting_intervals.py

dc669fa

Update application.py

4f91d5f

Update domainmodel.py

609f0fb

Update persistence.py

5450103

Update test_application.py

551bc4b

Update test_compression_and_encryption.py

d69682d

Update test_snapshotting_intervals.py

4816baa

MikeMitusov added 20 commits January 20, 2024 14:53

Update application.py

079d48a

Update system.py

ba9b19e

Update test_system.py

4caa1f7

Update application.py

33ea19c

Update persistence.py

2b1cbdd

Update postgres.py

dc7c0fe

Update sqlite.py

f9f85ce

Update test_application.py

f0c5ad4

Update test_recorder.py

8d8aa9a

Update test_invoice.py

1a51d9a

Update test_parking_lot.py

cf00272

Update application.py

a681b21

Update cipher.py

2d15304

Update compressor.py

cc19825

Update interface.py

0afe26f

Update persistence.py

dc6588a

Update popo.py

98031e3

Update postgres.py

5992776

Update sqlite.py

3a2c750

Update utils.py

cfb81d4

MikeMitusov closed this Jan 20, 2024

MikeMitusov deleted the fix-future branch January 20, 2024 15:37

MikeMitusov restored the fix-future branch January 20, 2024 15:37

MikeMitusov reopened this Jan 20, 2024

MikeMitusov closed this Jan 20, 2024

MikeMitusov deleted the fix-future branch January 20, 2024 18:14

johnbywater mentioned this pull request Jan 20, 2024

Fix future annotations (from #265) #266

Merged

johnbywater added a commit that referenced this pull request Jan 20, 2024

Merge pull request #266 from pyeventsourcing/pr-265-fix-future-annota…

9d78f09

…tions Fix future annotations (from #265) plus some changes to singledispatchmethod.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use future annotations #265

Use future annotations #265

MikeMitusov commented Jan 20, 2024 •

edited

Loading

johnbywater commented Jan 20, 2024

johnbywater commented Jan 20, 2024

Use __future__ annotations #265

Use __future__ annotations #265

Conversation

MikeMitusov commented Jan 20, 2024 • edited Loading

johnbywater commented Jan 20, 2024

johnbywater commented Jan 20, 2024

Use future annotations #265

Use future annotations #265

MikeMitusov commented Jan 20, 2024 •

edited

Loading