Added create_static method to Scene class. #117
Conversation
static webpages for the visualization. Added cleanup_static method to remove the static data generated!
|
@moorepants Please review and merge it. |
tarzzz
changed the title
|
This works. No need to open a server. Simply open index.html in your browser. Gonna add a couple of things before merging. |
Safety code is in place in create_static_html and remove_static_html to prevent unwanted deletions. I also changed the names of the methods to indicate more precisely what the methods do.
|
These really need tests before merging. Not sure how long that would take. @tarzzz, are you fine with the changes I made. |
| distutils.dir_util.remove_tree(os.path.join(os.getcwd(), '.pydy_viz')) | ||
| dst = os.path.join(os.getcwd(), 'static') | ||
|
|
||
| if os.path.exists(dst) and overwrite is False: |
There was a problem hiding this comment.
I am fine with the changes, but I feel we should be writing tests too for the same(because of conditional statements). I can write them and if we are short of time(sending tutorial instructions to students), then we can merge it and tests can be sent in a separate PR.
There was a problem hiding this comment.
This isn't critical to have for the tutorial, because we already have at least one browser/os combination that works for everyone. But if this was in a new pydy-viz release before the april 2, then we would have it available for backup in case the socket server isn't working for some.
|
@tarzzz You need to get this merged into the pydy repo. |
|
I am fine with the changes, but I feel we should be writing tests too for On Mon, Mar 31, 2014 at 7:37 AM, Jason K. Moore [email protected]:
|
|
Sorry, that was a draft I made some time ago(before PyCon). I am onto it On Wed, Apr 23, 2014 at 1:22 AM, TARUN GABA [email protected] wrote:
|
|
This would be great to have working in the scipy tutorial. Can you get this working in the new pydy repo? We plan to send out final instructions by June 23rd so it needs to be done sometime before that. |
It allows you to create static webpages for the visualization.
Added cleanup_static method to remove the static data generated!
To test this branch
modify last line in
pydy_examples/illustrative_example_for_viz/illustrative_example.pyfrom:
scene.display()to:
scene.create_static()and run it:
python illustrative_example.pythen cd to static directory generated, and from terminal
$ python -m SimpleHTTPServerYou should be able to see visualization at localhost:8000