Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] Adjust default StoragePresentationContexts to match DCMTK implementation #980

Merged
merged 6 commits into from
Dec 22, 2024

Conversation

mdebic
Copy link
Contributor

@mdebic mdebic commented Nov 12, 2024

Reference issue

Implementation as discussed in #978

Tasks

  • Unit tests added that reproduce issue or prove feature is working
  • Fix or feature added
  • Documentation and examples updated (if relevant)
  • Unit tests passing and coverage at 100% after adding fix/feature
  • Type annotations updated and passing with mypy
  • Apps updated and tested (if relevant)

@mdebic
Copy link
Contributor Author

mdebic commented Nov 12, 2024

@medihack

docs/user/ae.rst Outdated Show resolved Hide resolved
docs/user/ae.rst Outdated Show resolved Hide resolved
@scaramallion
Copy link
Member

Can you add an entry to the release notes as well please?

Copy link

codecov bot commented Nov 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (37ccf38) to head (886e6bb).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #980   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           28        28           
  Lines         8707      8709    +2     
=========================================
+ Hits          8707      8709    +2     
Files with missing lines Coverage Δ
pynetdicom/presentation.py 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

@mdebic
Copy link
Contributor Author

mdebic commented Dec 10, 2024

Can you add an entry to the release notes as well please?

Since I'm working together with @medihack, I discussed with him adding a v3 release note since his PR adding pydicom v3 support is a breaking change. Is this ok?

@mdebic
Copy link
Contributor Author

mdebic commented Dec 17, 2024

I did not see the separate folder for these integration tests, also not stated in the contribute.md. I will fix it.

@mdebic mdebic requested a review from scaramallion December 22, 2024 15:05
@scaramallion scaramallion merged commit c22be4b into pydicom:main Dec 22, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants