Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix handling of unverifiable and condition #34

Merged
merged 1 commit into from
Aug 8, 2023

Conversation

mrbean-bremen
Copy link
Member

- caused false positives
- fixes pydicom#32
@codecov-commenter
Copy link

Codecov Report

Merging #34 (45afd1e) into main (6bebe1e) will increase coverage by 0.49%.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #34      +/-   ##
==========================================
+ Coverage   87.62%   88.11%   +0.49%     
==========================================
  Files          14       14              
  Lines        1471     1473       +2     
==========================================
+ Hits         1289     1298       +9     
+ Misses        182      175       -7     
Files Changed Coverage Δ
dicom_validator/spec_reader/condition_parser.py 98.84% <100.00%> (+<0.01%) ⬆️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mrbean-bremen mrbean-bremen merged commit 549cfb7 into pydicom:main Aug 8, 2023
@mrbean-bremen mrbean-bremen deleted the invalid_and branch August 8, 2023 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Coding Scheme Version erroneously seen as required
2 participants